Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751341AbbGKT3T (ORCPT ); Sat, 11 Jul 2015 15:29:19 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:49544 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbbGKT3R (ORCPT ); Sat, 11 Jul 2015 15:29:17 -0400 Date: Sat, 11 Jul 2015 14:29:14 -0500 From: Felipe Balbi To: Subbaraya Sundeep Bhatta CC: "balbi@ti.com" , John Youn , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails Message-ID: <20150711192914.GA24195@saruman.tx.rr.com> Reply-To: References: <1432203408-5482-1-git-send-email-sbhatta@xilinx.com> <1432203408-5482-3-git-send-email-sbhatta@xilinx.com> <20150629214701.GK1019@saruman.tx.rr.com> <20150629214854.GL1019@saruman.tx.rr.com> <2B3535C5ECE8B5419E3ECBE3007729090175264F3B@US01WEMBX2.internal.synopsys.com> <20150702030009.GB29462@saruman.tx.rr.com> <2B3535C5ECE8B5419E3ECBE3007729090175267F20@US01WEMBX2.internal.synopsys.com> <20150707032448.GB13135@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ikeVEW9yuYc//A+q" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3309 Lines: 88 --ikeVEW9yuYc//A+q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sat, Jul 11, 2015 at 05:17:32PM +0000, Subbaraya Sundeep Bhatta wrote: > > > >> Hi Felipe, > > > >> > > > >> Just an update on this. > > > >> > > > >> I'm trying to get this working with our latest IP with dwc3 from > > > >> your testing/next branch. It fails the usbtest with a problem > > > >> unrelated to this patch. > > > >>. > > > >> It passes on 4.1.1. > > > >> > > > >> I'll have to look into the failure but I won't get to it until next > > > >> week as I'm off the rest of this week. > > > > > > > > interesting... If you could post failure signature, I can help > > > > looking at it, but I guess it's too late to ask :-) > > > > > > > > thanks for helping though > > > > > > > > > > > > > Hi Felipe, > > > > > > Nevermind about my issue, it ended up being a setup-related problem. > > > > > > I actually do see the same error as you due to this series of patches. > > > Except I see it happening before even the first iteration. I get a > > > completion status of 1 for the Set Endpoint Transfer Resources > > > command. I'm not sure why this is. > > > > > > I don't see any conflict with any previous Transfer Complete. >=20 > Same behavior at my end too. Fails before first iteration and I get > completion status of 1 for Set Endpoint Resource command. Attached the > logs of testing done with this patch and without this patch. > Without this patch I often see completion status of 1 for Set Endpoint > Transfer Resources command for Bulk and Isoc endpoints but test > proceeds because driver just logs command completion status and moves > on. We can revert this patch for time being. IP version is 2.90a. yeah, that's what I mean, it really seems like it's the IP misbehaving. John, let's try to figure out what's the root cause of this, we really want to use command completion status at some point, but for now we need to revert the patch :-( Let me know if you want me to log STARS ticket on your solvnet system. cheers --=20 balbi --ikeVEW9yuYc//A+q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVoW6KAAoJEIaOsuA1yqRE+8oP/10KS3KR3woIdGCO7zzKGjN3 MjFEVbz0aPlxdTkC94yB+uL7VM707uc179gPJ6XjQrolyVcBXRVD78Ler5xWBt5x 81OI1KBwWcUbfz/GemvsvgabG5zk/44Xg8pYDHTRxRrCO6Bq9POqHc+Rzlz9IkKY xUVTrUN0QNmBiuTKlBl+b9N+eb6SzwayS5H9BC9YQCQDdKiK/Zxm8UZTOLj2iq57 d+BnVYf+G7l6JaoaRebAosbjGi/VHuH5s5BTeJx6rawCJlF/x94T2DetamXtILaT msN2blluAWIZDA7a+qUehT4k7EYBs0uUmYVg1rGNCSG3xvX91rwYhcSCFUoXcVms jQPVsgW7aOhrZnxDkOyDTK0PR2pDS/Gt3pNhjfXYZOMaoz9SnYH9RBDFbLfZpykW g4c7VK2dm01JDQKB9DNa8N2FkTbT681fQSMYQxFh1ufJhtWItkTVljpt72hZw6PA w6NyiJ41rWTSbIC/MN7APWnc8ZQ6ds7l6jkTUNJBXpJBIST09uKSbo/Kvc7KHkir VuzQfgvC17p8M4VNim0poZmxTfSpxl/m+DKRTUa8vmkOaRW5880+8wSAvCBDdhph jBTAaDc8ozTwD9TqPQfRfFHc3VWJXF78u8AGQWQQUYPi3lWpFzjE48NkySvHm+XX yDkCOJpA/W/agwmEfMnD =VSJt -----END PGP SIGNATURE----- --ikeVEW9yuYc//A+q-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/