Date: Sat, 11 Jul 2015 22:36:26 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Alban Bedel <albeu@free.fr>
cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>,
        Andrew Bresticker <abrestic@chromium.org>,
        Qais Yousef <qais.yousef@imgtec.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: ath79: irq: Remove the include of
 drivers/irqchip/irqchip.h
In-Reply-To: <1436379071-31574-1-git-send-email-albeu@free.fr>
Message-ID: <alpine.DEB.2.11.1507112233280.20072@nanos>
References: <1436379071-31574-1-git-send-email-albeu@free.fr>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 979
Lines: 27

On Wed, 8 Jul 2015, Alban Bedel wrote:
> We shouldn't include irqchip.h from outside of the drivers/irqchip
> directory. The irq driver should idealy be there, however this not
> trivial at the moment. We still need to support platforms without DT
> support and the interface to the DDR controller still use a custom
> arch specific API.
> 
> For now just redefine the IRQCHIP_DECLARE macro to avoid the cross
> tree include.

The macro has been moved to linux/irqchip.h.

But even if it would still be in drivers/irqchip such a redefine is
even worse than the ../../... include. And the proper solution from
the very beginning would have been to move the macro to the global
header instead of this horrible include.

Sigh,

	tglx

 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/