Message-ID: <55A18AF1.9020404@lwfinger.net>
Date: Sat, 11 Jul 2015 16:30:25 -0500
From: Larry Finger <Larry.Finger@lwfinger.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: LKML <linux-kernel@vger.kernel.org>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
        Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Subject: Re: V4.1-RC build error after commit 77a3c6f
References: <55A18A48.7030007@lwfinger.net>
In-Reply-To: <55A18A48.7030007@lwfinger.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2001
Lines: 53

The subject should say V4.2-RC. Sorry.

Larry

On 07/11/2015 04:27 PM, Larry Finger wrote:
> Beginning with the commit in the subject, I get the following build error:
>
>    CC [M]  drivers/media/v4l2-core/videobuf2-core.o
> drivers/media/v4l2-core/videobuf2-core.c: In function ‘vb2_warn_zero_bytesused’:
> drivers/media/v4l2-core/videobuf2-core.c:1253:2: error: implicit declaration of
> function ‘__WARN’ [-Werror=implicit-function-declaration]
>    __WARN();
>    ^
> cc1: some warnings being treated as errors
>
> My .config is attached.
>
> This problem has been bisected to the following commit:
>
> commit 77a3c6fd90c94f635edb00d4a65f485687538791
> Author: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Date:   Fri Jun 19 08:50:07 2015 -0300
>
>      [media] vb2: Don't WARN when v4l2_buffer.bytesused is 0 for multiplanar
> buffers
>
>      Commit f61bf13b6a07 ("[media] vb2: add allow_zero_bytesused flag to the
>      vb2_queue struct") added a WARN_ONCE to catch usage of a deprecated API
>      using a zero value for v4l2_buffer.bytesused.
>
>      However, the condition is checked incorrectly, as the v4L2_buffer
>      bytesused field is supposed to be ignored for multiplanar buffers. This
>      results in spurious warnings when using the multiplanar API.
>
>      Fix it by checking v4l2_buffer.bytesused for uniplanar buffers and
>      v4l2_plane.bytesused for multiplanar buffers.
>
>      Fixes: f61bf13b6a07 ("[media] vb2: add allow_zero_bytesused flag to the
> vb2_queue struct")
>
>      Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>      Cc: stable@vger.kernel.org # for v4.0
>      Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
>
> Thanks,
>
> Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/