Message-ID: <55A1CA2E.10400@oracle.com>
Date: Sun, 12 Jul 2015 10:00:14 +0800
From: Bob Liu <bob.liu@oracle.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4
MIME-Version: 1.0
To: Jens Axboe <axboe@fb.com>
CC: linux-kernel@vger.kernel.org, hch@infradead.org,
        xen-devel@lists.xenproject.org, avanzini.arianna@gmail.com,
        david.vrabel@citrix.com, konrad.wilk@oracle.com,
        marcus.granado@citrix.com, roger.pau@citrix.com
Subject: Re: [PATCH v2] xen/blkfront: convert to blk-mq APIs
References: <1436621418-6742-1-git-send-email-bob.liu@oracle.com> <55A15D22.4020709@fb.com>
In-Reply-To: <55A15D22.4020709@fb.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1733
Lines: 49


On 07/12/2015 02:14 AM, Jens Axboe wrote:
> On 07/11/2015 07:30 AM, Bob Liu wrote:
>> Note: This patch is based on original work of Arianna's internship for
>> GNOME's Outreach Program for Women.
> 
> Great to see this finally get prepped to go in!
> 
>> Only one hardware queue is used now, so there is no performance change.
> 
> I would hope that the blk-mq path, even with one queue, is a perf win over the old interface. So I'm not sure that is correct. But the bigger win will be with more queues, of course.
> 

Right, but there are memory consumption and migration issues while using more hardware queues.
So I separated this patch from that big patchset and hope can be merged first.

>> The legacy non-mq code is deleted completely which is the same as other
>> drivers like virtio, mtip, and nvme.
>>
>> Also dropped one unnecessary holding of info->io_lock when calling
>> blk_mq_stop_hw_queues().
>>
>> Changes in v2:
>>   - Reorganized blk_mq_queue_rq()
>>   - Restored most io_locks in place
> 
> Looks good to me. The most common error case is the busy-out not stopping queues, or not restarting them at completion. But that all looks fine.
> 
> I would, however, rename blk_mq_queue_rq(). It sounds like a core function. blkif_queue_rq() would be more appropriate.
> 

Will send v3.

>> Signed-off-by: Arianna Avanzini <avanzini.arianna@gmail.com>
>> Signed-off-by: Bob Liu <bob.liu@oracle.com>
> 
> Acked-by: Jens Axboe <axboe@fb.com>
> 

Thank you!

-- 
Regards,
-Bob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/