Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752586AbbGLCIY (ORCPT ); Sat, 11 Jul 2015 22:08:24 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:59947 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752294AbbGLCIX (ORCPT ); Sat, 11 Jul 2015 22:08:23 -0400 Date: Sat, 11 Jul 2015 19:08:22 -0700 (PDT) Message-Id: <20150711.190822.1431177169987395247.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux@roeck-us.net, andrew@lunn.ch, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com Subject: Re: [PATCH v2] net: dsa: mv88e6xxx: add write access to debugfs regs file From: David Miller In-Reply-To: <1092744390.7730.1436639772848.JavaMail.zimbra@savoirfairelinux.com> References: <1436476409-5033-1-git-send-email-vivien.didelot@savoirfairelinux.com> <20150710.230120.1590955832899872718.davem@davemloft.net> <1092744390.7730.1436639772848.JavaMail.zimbra@savoirfairelinux.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 11 Jul 2015 19:08:22 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1194 Lines: 29 From: Vivien Didelot Date: Sat, 11 Jul 2015 14:36:12 -0400 (EDT) > In the meantime, this is really useful for development. i.e. ensuring a good > switchdev/DSA interaction without being able to read and write directly the > hardware VLAN table, is a bit a PITA. A dynamic debugfs looked appropriate. For "development" you can hack the driver, add tracepoints, or use another mechanism anyone hacking the kernel (which by definition someone doing "development" is doing) can do. I do not buy any of your arguments, and you really miss the grand opportunity to export the knobs and values in a way which are going to: 1) Be useful to users 2) Be usable by any similar DSA driver, not just _yours_ So please stop this myopic narrow thinking when you add facilities for development or export values. Think of the big picture and long term, not just your personal perceived immediate needs of today. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/