Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750879AbbGLEOc (ORCPT ); Sun, 12 Jul 2015 00:14:32 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:29242 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750709AbbGLEOb (ORCPT ); Sun, 12 Jul 2015 00:14:31 -0400 Date: Sat, 11 Jul 2015 21:13:54 -0700 From: Calvin Owens To: Christoph Hellwig CC: Nagalakshmi Nandigama , Praveen Krishnamoorthy , Sreekanth Reddy , Abhijit Mahajan , , , , Subject: Re: [PATCH 5/6] Refactor code to use new fw_event refcount Message-ID: <20150712041354.GA4002764@mail.thefacebook.com> References: <1431661322-3097935-1-git-send-email-calvinowens@fb.com> <1433821856-2815280-1-git-send-email-calvinowens@fb.com> <1433821856-2815280-6-git-send-email-calvinowens@fb.com> <20150703160033.GA11815@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <20150703160033.GA11815@infradead.org> User-Agent: Mutt/1.5.20 (2009-12-10) X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-07-12_04:2015-07-11,2015-07-12,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1095 Lines: 22 Thanks for this, I'm sending a v2 shortly. On Friday 07/03 at 09:00 -0700, Christoph Hellwig wrote: > On Mon, Jun 08, 2015 at 08:50:55PM -0700, Calvin Owens wrote: > > This refactors the fw_event code to use the new refcount. > > I spent some time looking over this code because it's so convoluted. > In general I think code should either embeed one work_struct (and it > really doesn't seem to need a delayed work here!) or if needed a list > and not both like this one. But it's probably too much work to sort > all this out, so let's go with your version. Yeah, I tried to get rid of fw_event_list altogether, since I think what cleanup_queue() does could be simplified to calling flush_workqueue(). The problem is _scsih_check_topo_delete_events(), which looks at the list and sometimes marks fw_events as "ignored" so they aren't executed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/