Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752289AbbGLKaP (ORCPT ); Sun, 12 Jul 2015 06:30:15 -0400 Received: from ms1.cdi.cz ([93.90.167.38]:58336 "EHLO ms1.cdi.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751720AbbGLKaN (ORCPT ); Sun, 12 Jul 2015 06:30:13 -0400 X-Greylist: delayed 723 seconds by postgrey-1.27 at vger.kernel.org; Sun, 12 Jul 2015 06:30:13 EDT Message-Id: From: Martin Devera Date: Sun, 12 Jul 2015 12:00:01 +0200 Subject: [PATCH] Fix ARM LPC32XX platform broken by older commit X-CDI-Malware-Check: OK X-Spam-Score: -0.6 (/) To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1128 Lines: 32 In commit a71b092a9c68685a270ebdde7b5986ba8787e575 __handle_domain_irq was introduced by Marc Zyngier. It tests hwirq on zero and rejects it. At least LPC32XX uses IRQ 0 as chained entry for SIC1. Thus all SIC1 connected devices doesn't work just now. This patch fixes it - not sure whether it is correct way however. --- kernel/irq/irqdesc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c index 99793b9..3c90794 100644 --- a/kernel/irq/irqdesc.c +++ b/kernel/irq/irqdesc.c @@ -381,7 +381,7 @@ int __handle_domain_irq(struct irq_domain *domain, unsigned int hwirq, * Some hardware gives randomly wrong interrupts. Rather * than crashing, do something sensible. */ - if (unlikely(!irq || irq >= nr_irqs)) { + if (unlikely(irq >= nr_irqs)) { ack_bad_irq(irq); ret = -EINVAL; } else { -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/