Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751210AbbGLPqB (ORCPT ); Sun, 12 Jul 2015 11:46:01 -0400 Received: from mail-oi0-f53.google.com ([209.85.218.53]:35858 "EHLO mail-oi0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbbGLPp7 (ORCPT ); Sun, 12 Jul 2015 11:45:59 -0400 MIME-Version: 1.0 In-Reply-To: <1436711211-18223-11-git-send-email-robh@kernel.org> References: <1436711211-18223-1-git-send-email-robh@kernel.org> <1436711211-18223-11-git-send-email-robh@kernel.org> Date: Mon, 13 Jul 2015 00:45:58 +0900 Message-ID: Subject: Re: [PATCH v2 10/13] pinctrl: kill off set_irq_flags usage From: Tomasz Figa To: Rob Herring Cc: linux-arm-kernel , Russell King , linux-kernel , "arm@kernel.org" , Stephen Warren , Lee Jones , Matthias Brugger , Thomas Abraham , Kukjin Kim , Krzysztof Kozlowski , "linux-gpio@vger.kernel.org" , linux-rpi-kernel , linux-mediatek@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2125 Lines: 52 Hi, 2015-07-12 23:26 GMT+09:00 Rob Herring : > set_irq_flags is ARM specific with custom flags which have genirq > equivalents. Convert drivers to use the genirq interfaces directly, so we > can kill off set_irq_flags. The translation of flags is as follows: > > IRQF_VALID -> !IRQ_NOREQUEST > IRQF_PROBE -> !IRQ_NOPROBE > IRQF_NOAUTOEN -> IRQ_NOAUTOEN > > For IRQs managed by an irqdomain, the irqdomain core code handles clearing > and setting IRQ_NOREQUEST already, so there is no need to do this in > .map() functions and we can simply remove the set_irq_flags calls. Some > users also set IRQ_NOPROBE and this has been maintained although it is not > clear that is really needed. There appears to be a great deal of blind > copy and paste of this code. > > Signed-off-by: Rob Herring > Acked-by: Linus Walleij > Cc: Stephen Warren > Cc: Lee Jones > Cc: Matthias Brugger > Cc: Tomasz Figa > Cc: Thomas Abraham > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: linux-gpio@vger.kernel.org > Cc: linux-rpi-kernel@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > --- > drivers/pinctrl/bcm/pinctrl-bcm2835.c | 1 - > drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 -- > drivers/pinctrl/pinctrl-single.c | 5 ----- > drivers/pinctrl/samsung/pinctrl-exynos.c | 1 - > drivers/pinctrl/samsung/pinctrl-exynos5440.c | 1 - > drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 2 -- > drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 2 -- For drivers/pinctrl/samsung: Acked-by: Tomasz Figa Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/