Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751318AbbGLP45 (ORCPT ); Sun, 12 Jul 2015 11:56:57 -0400 Received: from mail-ob0-f178.google.com ([209.85.214.178]:34254 "EHLO mail-ob0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750766AbbGLP44 (ORCPT ); Sun, 12 Jul 2015 11:56:56 -0400 Message-ID: <55A28E44.8020202@lwfinger.net> Date: Sun, 12 Jul 2015 10:56:52 -0500 From: Larry Finger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Joe Perches CC: Arnd Bergmann , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bug: Fix build error in V4.2-RC1 References: <1436713236-26445-1-git-send-email-Larry.Finger@lwfinger.net> <1436716328.2711.77.camel@perches.com> In-Reply-To: <1436716328.2711.77.camel@perches.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 808 Lines: 26 On 07/12/2015 10:52 AM, Joe Perches wrote: > On Sun, 2015-07-12 at 10:00 -0500, Larry Finger wrote: >> If CONFIG_BUG is not defined, then macro __WARN is not defined. > [] >> diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h > [] >> @@ -137,6 +137,7 @@ extern void warn_slowpath_null(const char *file, const int line); > >> +#define __WARN() do {} while (1) > > Do you really think WARN should loop forever? Obviously not. I copied the code in that section for BUG() without thinking. On to V2 after I get some more feedback. Thanks, Larry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/