Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751486AbbGLXKH (ORCPT ); Sun, 12 Jul 2015 19:10:07 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:34773 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751281AbbGLXKF convert rfc822-to-8bit (ORCPT ); Sun, 12 Jul 2015 19:10:05 -0400 From: Laurent Pinchart To: Larry Finger Cc: LKML , Laurent Pinchart , Mauro Carvalho Chehab Subject: Re: V4.1-RC build error after commit 77a3c6f Date: Mon, 13 Jul 2015 02:10:23 +0300 Message-ID: <15791242.3vaIcGi6Sg@avalon> User-Agent: KMail/4.14.8 (Linux/4.0.5-gentoo; KDE/4.14.8; x86_64; ; ) In-Reply-To: <55A18A48.7030007@lwfinger.net> References: <55A18A48.7030007@lwfinger.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2288 Lines: 68 Hi Larry, Thank you for the report. On Saturday 11 July 2015 16:27:36 Larry Finger wrote: > Beginning with the commit in the subject, I get the following build error: > > CC [M] drivers/media/v4l2-core/videobuf2-core.o > drivers/media/v4l2-core/videobuf2-core.c: In function > ‘vb2_warn_zero_bytesused’: drivers/media/v4l2-core/videobuf2-core.c:1253:2: > error: implicit declaration of function ‘__WARN’ > [-Werror=implicit-function-declaration] > __WARN(); > ^ > cc1: some warnings being treated as errors > > My .config is attached. Indeed, __WARN isn't defined when CONFIG_BUG isn't set. My bad :-/ I've send a patch to fix this (you've been CC'ed), could you please review it ? And I've just noticed that I forgot to add your Reported-by: tag, please feel free to add it to the review. > This problem has been bisected to the following commit: > > commit 77a3c6fd90c94f635edb00d4a65f485687538791 > Author: Laurent Pinchart > Date: Fri Jun 19 08:50:07 2015 -0300 > > [media] vb2: Don't WARN when v4l2_buffer.bytesused is 0 for multiplanar > buffers > > Commit f61bf13b6a07 ("[media] vb2: add allow_zero_bytesused flag to the > vb2_queue struct") added a WARN_ONCE to catch usage of a deprecated API > using a zero value for v4l2_buffer.bytesused. > > However, the condition is checked incorrectly, as the v4L2_buffer > bytesused field is supposed to be ignored for multiplanar buffers. This > results in spurious warnings when using the multiplanar API. > > Fix it by checking v4l2_buffer.bytesused for uniplanar buffers and > v4l2_plane.bytesused for multiplanar buffers. > > Fixes: f61bf13b6a07 ("[media] vb2: add allow_zero_bytesused flag to the > vb2_queue struct") > > Signed-off-by: Laurent Pinchart > Cc: stable@vger.kernel.org # > for v4.0 > Signed-off-by: Mauro Carvalho Chehab > > Thanks, > > Larry -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/