Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751678AbbGLXg4 (ORCPT ); Sun, 12 Jul 2015 19:36:56 -0400 Received: from mail-vn0-f52.google.com ([209.85.216.52]:40532 "EHLO mail-vn0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751505AbbGLXgz (ORCPT ); Sun, 12 Jul 2015 19:36:55 -0400 MIME-Version: 1.0 In-Reply-To: <1436738358-19546-1-git-send-email-ulfalizer@gmail.com> References: <1436738358-19546-1-git-send-email-ulfalizer@gmail.com> Date: Sun, 12 Jul 2015 16:36:53 -0700 Message-ID: Subject: Re: [PATCH] DocBook: Avoid stdout junk with no man pages to compress From: Jim Davis To: Ulf Magnusson Cc: linux-kernel , linux-doc , Michal Marek , Jonathan Corbet , Herbert Xu , smueller@chronox.de, Ulf Magnusson Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1479 Lines: 38 On Sun, Jul 12, 2015 at 2:59 PM, Ulf Magnusson wrote: > gzip would run as 'gzip -f' when no uncompressed man pages were found, > making it compress the (empty) stdin to stdout. > --- a/Documentation/DocBook/Makefile > +++ b/Documentation/DocBook/Makefile > @@ -56,7 +56,7 @@ htmldocs: $(HTML) > > MAN := $(patsubst %.xml, %.9, $(BOOKS)) > mandocs: $(MAN) > - find $(obj)/man -name '*.9' | xargs gzip -f > + find $(obj)/man -name '*.9' -exec gzip -f {} \; > > installmandocs: mandocs > mkdir -p /usr/local/man/man9/ That does get rid of the binary burp, but 'xargs gzip -f' has been in the Makefile since January, and gzipping '\n' just started recently. So what's changed? It looks like, for whatever reason, make installmandocs always ends up rerunning mandocs -- there's now a 'GEN Documentation Docbook//v4l2.xml' printed, and that extra mandocs invocation is where the problematic second invocation of find is coming from. I won't pretend to understand the Makefile flow to guess at why that's happening, but obviously 'make mandocs; make installmandocs' shouldn't need to regenerate things already generated. In any event, Tested-by: Jim Davis Jim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/