Date: Mon, 13 Jul 2015 10:00:25 +0800
From: Peter Chen <peter.chen@freescale.com>
To: Roger Quadros <rogerq@ti.com>
CC: <stern@rowland.harvard.edu>, <balbi@ti.com>, <gregkh@linuxfoundation.org>,
        <dan.j.williams@intel.com>, <jun.li@freescale.com>,
        <mathias.nyman@linux.intel.com>, <tony@atomide.com>,
        <Joao.Pinto@synopsys.com>, <linux-usb@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v3 05/11] usb: hcd.h: Add OTG to HCD interface
Message-ID: <20150713020024.GD27710@shlinux2>
References: <1436350777-28056-1-git-send-email-rogerq@ti.com>
 <1436350777-28056-6-git-send-email-rogerq@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1436350777-28056-6-git-send-email-rogerq@ti.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2015 03:09:29.3748
 (UTC)
X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1226
X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB0860;2:/+eCbp6BP229Tn9J+ux87HCXM/PiYbTMuydOCrpBRkfh9twGUcSJBqxViTqRfq5M;3:jOS/AuI9eSzPdW/+ODHZ053gdIumf8IHFUTMZkqljVHt/uSSnKoBGqIEiMWJZOjMBCopCQEqVvqe1ksC4apNhXmYcRjB9arDglGsF76tlIpK+4sPrjuEzOPTn8QzOx/dmZoYYh0sgMS9hNrKSdCohYHLHtfZdV97I4EtfWPsD2i3dx+1vtmDl1CfXGLL22fsmzDCzX4jntw1G4plaPUgmnPUT+C+VK095xo8k+zkzz4=;25:j4EWCk6J9ggvXQa2esOgwyWlh2gZyKtd0jp60BKbN87wptl7Egnh59W8wt2a/pcM+W3U4YYZPRE0pbLWDrCE6zQDAo0bodKQKRAJ4Dayt5MbVEHNptCgWSTVEmSjQjtiBrOJ2SP5b8KXdHj0czKAKwj7qYLnAufSxjH3EKbuKBRGve2wrSpEx8cT8+ILoLR1+gwIKg8qTx7vpJrrZOt3mbAQaZpTYZjkA2oP30r1goFM5MLguywB53s50CQlrxo+hvYmLlu9DIG5FgcNU/kZhg==;23:+xfl/tljSnCBRiFMtD7eWQVAUyHLk5Ih0LFfsjhOWfpYeZOLSKh0v55BXacd7FqOk3NYHUX7CHl4x/Gr1VaLA/kyCQInM+9e3GS7E2Dr7jJJ9qbl2bECPFEc6lsyF2ONSW5lSYfRjJGlBKT9MTRbVuMuArwAChZRl1Z1pjBBCxzyMrGgNz9KUGEjXha2JAy1TJRGQCtM/JWKMjE2QxULL1zKpXSPJWO2UoXyejHxTytWhIA9nSS0QR1HcRqPiZ6z
X-OriginatorOrg: freescale.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1601
Lines: 58

On Wed, Jul 08, 2015 at 01:19:31PM +0300, Roger Quadros wrote:
> The OTG core will use struct otg_hcd_ops to
> add/remove the HCD controller.
> 
> The main purpose of this interface is to avoid directly
> calling usb_add/remove_hcd() from the OTG core as they
> wouldn't be defined in the built-in symbol table if
> CONFIG_USB is m.
> 

Like patch 4, Would you let the OTG depends on HCD?
OTG needs dual-role, it is reasonable.

Peter

> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>  include/linux/usb/hcd.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
> index c9aa779..4108288 100644
> --- a/include/linux/usb/hcd.h
> +++ b/include/linux/usb/hcd.h
> @@ -386,6 +386,20 @@ struct hc_driver {
>  
>  };
>  
> +/**
> + * struct otg_hcd_ops - Interface between OTG core and HCD
> + *
> + * Provided by the HCD core to allow the OTG core to start/stop the HCD
> + *
> + * @add: function to add the HCD
> + * @remove: function to remove the HCD
> + */
> +struct otg_hcd_ops {
> +	int (*add)(struct usb_hcd *hcd,
> +		   unsigned int irqnum, unsigned long irqflags);
> +	void (*remove)(struct usb_hcd *hcd);
> +};
> +
>  static inline int hcd_giveback_urb_in_bh(struct usb_hcd *hcd)
>  {
>  	return hcd->driver->flags & HCD_BH;
> -- 
> 2.1.4
> 

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/