Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751936AbbGMCtc (ORCPT ); Sun, 12 Jul 2015 22:49:32 -0400 Received: from mail-qk0-f180.google.com ([209.85.220.180]:32985 "EHLO mail-qk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751855AbbGMCt3 (ORCPT ); Sun, 12 Jul 2015 22:49:29 -0400 From: Peter Hurley To: Greg Kroah-Hartman Cc: Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Peter Hurley Subject: [PATCH 0/7] tty core debug patches Date: Sun, 12 Jul 2015 22:49:06 -0400 Message-Id: <1436755753-7746-1-git-send-email-peter@hurleysoftware.com> X-Mailer: git-send-email 2.4.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1744 Lines: 45 Hi Greg, This patchset replaces the printk(KERN_DEBUG) uses in the tty core with a common tty_debug(tty, ...) base macro, folding in the common elements of tty name and function name. The many inline #ifdef TTY_SOME_DEBUG_FLAG printk's are replaced with macro equivalents which reduce to tty_debug(). Several important improvements include: * patch 1/7 adds the tty count to the tty_open() message * patch 6/7 improve the ldisc messages to aid in state debugging * patch 7/7 adds pmtx open (which helps clarify when the master was opened) An important outcome of a single tty_debug() macro is that it can be trivially changed to use a different debug facility than console; for example, for some of my torture tests using the ftrace facility is much less intrusive. I would expect that to remain a local change though. Regards, Peter Hurley (7): tty: core: Improve debug message content tty: core: Add tty_debug() for printk(KERN_DEBUG) messages tty: Replace #ifdef TTY_DEBUG_HANGUP with tty_debug_hangup() tty: Use tty_debug() for tty_ldisc_debug() tty: Replace inline #ifdef TTY_DEBUG_WAIT_UNTIL_SENT tty: core: Improve ldisc debug messages pty: Add debug message for ptmx open drivers/tty/pty.c | 8 ++++++ drivers/tty/tty_io.c | 67 +++++++++++++++++++------------------------------ drivers/tty/tty_ioctl.c | 11 +++++--- drivers/tty/tty_ldisc.c | 15 ++++++----- include/linux/tty.h | 6 +++++ 5 files changed, 55 insertions(+), 52 deletions(-) -- 2.4.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/