Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752427AbbGMDZQ (ORCPT ); Sun, 12 Jul 2015 23:25:16 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:38857 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751729AbbGMDZO (ORCPT ); Sun, 12 Jul 2015 23:25:14 -0400 Date: Sun, 12 Jul 2015 20:25:13 -0700 (PDT) Message-Id: <20150712.202513.301354636371108143.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux@roeck-us.net, andrew@lunn.ch, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com Subject: Re: [PATCH v2] net: dsa: mv88e6xxx: add write access to debugfs regs file From: David Miller In-Reply-To: <1788707459.58885.1436751570981.JavaMail.zimbra@savoirfairelinux.com> References: <1092744390.7730.1436639772848.JavaMail.zimbra@savoirfairelinux.com> <20150711.190822.1431177169987395247.davem@davemloft.net> <1788707459.58885.1436751570981.JavaMail.zimbra@savoirfairelinux.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 12 Jul 2015 20:25:14 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 875 Lines: 20 From: Vivien Didelot Date: Sun, 12 Jul 2015 21:39:30 -0400 (EDT) > I hardly see how this debug interface can be made generic to other > DSA drivers, since the format of hardware tables or some registers > seem very specific to the switch chip. You feel this way because you are focusing on register values and not what those values represent. Ie. could you export the values in those registers in a generic format that other devices could convert their register values to as well? Stop focusing so tightly on the exact thing you've implemented and consider things on a much higher level. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/