Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751934AbbGMEZl (ORCPT ); Mon, 13 Jul 2015 00:25:41 -0400 Received: from mail-qk0-f182.google.com ([209.85.220.182]:32777 "EHLO mail-qk0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750831AbbGMEZk (ORCPT ); Mon, 13 Jul 2015 00:25:40 -0400 Message-ID: <55A33DC1.9030505@hurleysoftware.com> Date: Mon, 13 Jul 2015 00:25:37 -0400 From: Peter Hurley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Joe Perches CC: Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 2/7] tty: core: Add tty_debug() for printk(KERN_DEBUG) messages References: <1436755753-7746-1-git-send-email-peter@hurleysoftware.com> <1436755753-7746-3-git-send-email-peter@hurleysoftware.com> <1436759238.2711.86.camel@perches.com> In-Reply-To: <1436759238.2711.86.camel@perches.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1339 Lines: 46 On 07/12/2015 11:47 PM, Joe Perches wrote: > On Sun, 2015-07-12 at 22:49 -0400, Peter Hurley wrote: >> Introduce tty_debug() macro to output uniform debug information for >> tty core debug messages (function name and tty name). > [] >> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c > [] >> @@ -768,7 +768,7 @@ static void do_tty_hangup(struct work_struct *work) >> void tty_hangup(struct tty_struct *tty) >> { >> #ifdef TTY_DEBUG_HANGUP >> - printk(KERN_DEBUG "%s hangup...\n", tty_name(tty)); >> + tty_debug(tty, "\n"); > > Why drop the "hangup..." ? tty_debug() prints the function name; in this case, tty_hangup(). >> diff --git a/include/linux/tty.h b/include/linux/tty.h > [] >> +#define tty_debug(tty, f, args...) \ >> + do { \ >> + printk(KERN_DEBUG "%s: %s: " f, __func__, \ >> + tty_name(tty), ##args); \ >> + } while (0) > > Single statement macros don't need do {} while (0) Ah, yep. Old hold-over from when tty_name() needed a temp buffer. > #define fmt, ... > using fmt, ##__VA_ARGS__ > > is more common. Ok. Regards, Peter Hurley -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/