Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751174AbbGMEwN (ORCPT ); Mon, 13 Jul 2015 00:52:13 -0400 Received: from mail-yk0-f173.google.com ([209.85.160.173]:36402 "EHLO mail-yk0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750804AbbGMEwL (ORCPT ); Mon, 13 Jul 2015 00:52:11 -0400 MIME-Version: 1.0 In-Reply-To: <1435126625-9634-3-git-send-email-s.hauer@pengutronix.de> References: <1435126625-9634-1-git-send-email-s.hauer@pengutronix.de> <1435126625-9634-3-git-send-email-s.hauer@pengutronix.de> From: Daniel Kurtz Date: Mon, 13 Jul 2015 12:51:50 +0800 X-Google-Sender-Auth: 6-XqUQUaxIxcizKE_37Q5Xu5ud4 Message-ID: Subject: Re: [PATCH 2/4] dt-bindings: soc: Add documentation for the MediaTek SCPSYS unit To: Sascha Hauer Cc: "linux-arm-kernel@lists.infradead.org" , "open list:OPEN FIRMWARE AND..." , Kevin Hilman , "linux-kernel@vger.kernel.org" , linux-mediatek@lists.infradead.org, Sasha Hauer , Matthias Brugger Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3146 Lines: 78 On Wed, Jun 24, 2015 at 2:17 PM, Sascha Hauer wrote: > This adds documentation for the MediaTek SCPSYS unit found in MT8173 SoCs. > > Signed-off-by: Sascha Hauer > --- > .../devicetree/bindings/soc/mediatek/scpsys.txt | 41 ++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > > diff --git a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > new file mode 100644 > index 0000000..c051114 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > @@ -0,0 +1,41 @@ > +MediaTek SCPSYS > +=============== > + > +The System Control Processor System (SCPSYS) has several power management > +related tasks in the system. The tasks include thermal measurement, dynamic > +voltage frequency scaling (DVFS), interrupt filter and lowlevel sleep control. > +The System Power Manager (SPM) inside the SCPSYS is for the MTCMOS power > +domain control. > + > +The driver implements the Generic PM domain bindings described in > +power/power_domain.txt. It provides the power domains defined in > +include/dt-bindings/power/mt8173-power.h. > + > +Required properties: > +- compatible: Must be "mediatek,mt8173-scpsys" > +- #power-domain-cells: Must be 1 > +- reg: Address range of the SCPSYS unit > +- infracfg: must contain a phandle to the infracfg controller > +- clock, clock-names: clocks according to the common clock binding. > + The clocks needed "mm" and "mfg". These are the > + clocks which hardware needs to be enabled before > + enabling certain power domains. > + > +Example: > + > + scpsys: scpsys@10006000 { Perhaps it is too late, and/or too pedantic, but, since this node defines a PM domain provider as defined in [0], shouldn't its node have been the more generic: scpsys: power-controller@10006000 [0] /Documentation/devicetree/bindings/power/power_domain.txt > + #power-domain-cells = <1>; > + compatible = "mediatek,mt8173-scpsys"; > + reg = <0 0x10006000 0 0x1000>; > + infracfg = <&infracfg>; > + clocks = <&clk26m>, > + <&topckgen CLK_TOP_MM_SEL>; > + clock-names = "mfg", "mm"; > + }; > + > +Example consumer: > + > + afe: mt8173-afe-pcm@11220000 { > + compatible = "mediatek,mt8173-afe-pcm"; > + power-domains = <&scpsys MT8173_POWER_DOMAIN_AUDIO>; > + }; > -- > 2.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/