Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751535AbbGMGfs (ORCPT ); Mon, 13 Jul 2015 02:35:48 -0400 Received: from mga02.intel.com ([134.134.136.20]:58526 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750804AbbGMGfr (ORCPT ); Mon, 13 Jul 2015 02:35:47 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,461,1432623600"; d="scan'208";a="523278690" Message-ID: <55A35BA4.8020800@intel.com> Date: Mon, 13 Jul 2015 14:33:08 +0800 From: Pan Xinhui User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "Rafael J. Wysocki" CC: Linux Kernel Mailing List , "linux-pm@vger.kernel.org" , "rjw@rjwysocki.net" , Viresh Kumar , "yanmin_zhang@linux.intel.com" , "mnipxh@163.com" Subject: Re: [PATCH] acpi-cpufreq: Add a miss ifdef CONFIG_X86_ACPI_CPUFREQ_CPB References: <559F5D13.8050104@intel.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1945 Lines: 56 hi, Rafeal thanks for your reply. :) On 2015年07月11日 04:44, Rafael J. Wysocki wrote: > Hi, > > On Fri, Jul 10, 2015 at 7:50 AM, Pan Xinhui wrote: >> >> If CONFIG_X86_ACPI_CPUFREQ_CPB has not been defined, the placeholder for >> cpb is not needed. Add ifdef around it. >> >> Signed-off-by: Pan Xinhui >> --- >> drivers/cpufreq/acpi-cpufreq.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c >> index e7fcaa6..314a19e 100644 >> --- a/drivers/cpufreq/acpi-cpufreq.c >> +++ b/drivers/cpufreq/acpi-cpufreq.c >> @@ -884,7 +884,9 @@ static int acpi_cpufreq_resume(struct cpufreq_policy *policy) >> static struct freq_attr *acpi_cpufreq_attr[] = { >> &cpufreq_freq_attr_scaling_available_freqs, >> &freqdomain_cpus, >> +#ifdef CONFIG_X86_ACPI_CPUFREQ_CPB >> NULL, /* this is a placeholder for cpb, do not remove */ >> +#endif > > Adding the ifdef here doesn't change anything, because the next NULL > will play the role of the one you've just #ifdefed and the structure > will be filled with zeros from that point on anyway. > Yes, adding ifdef here does not change any binary codes. But I want to make the codes more readable. :) Patch author has noticed two *NULL* here would confuse people, especially who first read this acpi-cpufreq.c file >From code style point, it would be better to have #ifdef around it. > You'd need to #ifdef it in the struct freq_attr definition, but I'm > not sure it's worth the effort. > struct freq_attr *cpb* is defined in #ifdef section. :) thanks xinhui >> NULL, >> }; > > Thanks, > Rafael > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/