Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751819AbbGMHOq (ORCPT ); Mon, 13 Jul 2015 03:14:46 -0400 Received: from mail-oi0-f48.google.com ([209.85.218.48]:33665 "EHLO mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751214AbbGMHOn (ORCPT ); Mon, 13 Jul 2015 03:14:43 -0400 MIME-Version: 1.0 In-Reply-To: <20150712220211.7166.42035.stgit@bhelgaas-glaptop2.roam.corp.google.com> References: <20150712215559.7166.33068.stgit@bhelgaas-glaptop2.roam.corp.google.com> <20150712220211.7166.42035.stgit@bhelgaas-glaptop2.roam.corp.google.com> Date: Mon, 13 Jul 2015 09:14:42 +0200 X-Google-Sender-Auth: 7R0N7i4z0f4c4ksmekqFkKUYq28 Message-ID: Subject: Re: [PATCH 3/3] IRQ: Print "unexpected IRQ" messages consistently across architectures From: Geert Uytterhoeven To: Bjorn Helgaas Cc: Thomas Gleixner , Linux-Arch , Linux MIPS Mailing List , "moderated list:PANASONIC MN10300..." , "linux-ia64@vger.kernel.org" , linux-c6x-dev@linux-c6x.org, Parisc List , linux-s390 , Linux-sh list , "adi-buildroot-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , linux-m68k , alpha , "the arch/x86 maintainers" , "linuxppc-dev@lists.ozlabs.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1392 Lines: 38 On Mon, Jul 13, 2015 at 12:02 AM, Bjorn Helgaas wrote: > Many architectures use a variant of "unexpected IRQ trap at vector %x" to > log unexpected IRQs. This is confusing because (a) it prints the Linux IRQ > number, but "vector" more often refers to a CPU vector number, and (b) it > prints the IRQ number in hex with no base indication, while Linux IRQ > numbers are usually printed in decimal. > > Print the same text ("unexpected IRQ %d") across all architectures. > > No functional change other than the output text. > > Signed-off-by: Bjorn Helgaas > --- Thanks! > arch/m68k/include/asm/hardirq.h | 2 +- For m68k: Acked-by: Geert Uytterhoeven And it looks like m68k can switch to the asm-generic version afterwards... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/