Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751481AbbGMMBw (ORCPT ); Mon, 13 Jul 2015 08:01:52 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:43980 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750792AbbGMMBu (ORCPT ); Mon, 13 Jul 2015 08:01:50 -0400 Date: Mon, 13 Jul 2015 15:01:30 +0300 From: Dan Carpenter To: Mateusz Kulikowski Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/22] staging: rtl8192e: Remove unused fields from rtllib_stats Message-ID: <20150713120129.GX4341@mwanda> References: <1436732972-30175-1-git-send-email-mateusz.kulikowski@gmail.com> <1436732972-30175-6-git-send-email-mateusz.kulikowski@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436732972-30175-6-git-send-email-mateusz.kulikowski@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1549 Lines: 43 On Sun, Jul 12, 2015 at 10:29:15PM +0200, Mateusz Kulikowski wrote: > diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h > index 8ba92ed..dc0653a 100644 > --- a/drivers/staging/rtl8192e/rtllib.h > +++ b/drivers/staging/rtl8192e/rtllib.h > @@ -691,27 +691,8 @@ struct rtllib_frag_entry { > }; > > struct rtllib_stats { > - unsigned int tx_unicast_frames; > - unsigned int tx_multicast_frames; > - unsigned int tx_fragments; > - unsigned int tx_unicast_octets; > - unsigned int tx_multicast_octets; > - unsigned int tx_deferred_transmissions; > - unsigned int tx_single_retry_frames; > - unsigned int tx_multiple_retry_frames; > - unsigned int tx_retry_limit_exceeded; > unsigned int tx_discards; > - unsigned int rx_unicast_frames; > - unsigned int rx_multicast_frames; > - unsigned int rx_fragments; > - unsigned int rx_unicast_octets; > - unsigned int rx_multicast_octets; > - unsigned int rx_fcs_errors; > - unsigned int rx_discards_no_buffer; > - unsigned int tx_discards_wrong_sa; > unsigned int rx_discards_undecryptable; > - unsigned int rx_message_in_msg_fragments; > - unsigned int rx_message_in_bad_msg_fragments; > }; The remaining two struct members seem to be set but not used. Can you remove them as well in a later patch? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/