Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751494AbbGMMyT (ORCPT ); Mon, 13 Jul 2015 08:54:19 -0400 Received: from smtp3a.wifcom.cz ([37.157.193.67]:60678 "EHLO smtp.wifcom.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750792AbbGMMyS (ORCPT ); Mon, 13 Jul 2015 08:54:18 -0400 X-Greylist: delayed 1643 seconds by postgrey-1.27 at vger.kernel.org; Mon, 13 Jul 2015 08:54:18 EDT Message-ID: <55A3AE66.1070705@cdi.cz> Date: Mon, 13 Jul 2015 14:26:14 +0200 From: Martin Devera User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: Paul Bolle CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] Add NXP LPC32XX SPI driver References: <1436789948.2679.23.camel@tiscali.nl> In-Reply-To: <1436789948.2679.23.camel@tiscali.nl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus-Scanner: Clean mail though you should still use an Antivirus X-Wif-ss: () Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1041 Lines: 31 Paul Bolle wrote: > (This hit my box with lkml mesages without lkml in the To: header. What > happened here?) Ahh, have to check my sending script .. > On zo, 2015-07-12 at 11:20 +0200, Martin Devera wrote: >> --- /dev/null >> +++ b/drivers/spi/spi-lpc32xx.c > >> +#define DRIVER_NAME "spi-lpc32xx" > >> +MODULE_ALIAS("platform:" DRIVER_NAME); > > This alias seems only useful if there's a corresponding struct > platform_device. Ie, a struct platform_device with a .name of "spi > -lpc32xx", which will fire off a "MODALIAS=platform:spi-lpc32xx" uevent > when it's created. My fault, thanks for spotting. It is leftover from driver I used as template... In any case, I has other comments from Joachim Eastwood thus I plan to do more cleanup and resubmit the driver later.. thanks, Martin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/