Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751636AbbGMMrc (ORCPT ); Mon, 13 Jul 2015 08:47:32 -0400 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:34165 "EHLO e06smtp14.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750856AbbGMMr3 (ORCPT ); Mon, 13 Jul 2015 08:47:29 -0400 X-Helo: d06dlp02.portsmouth.uk.ibm.com X-MailFrom: sebott@linux.vnet.ibm.com X-RcptTo: linux-s390@vger.kernel.org Date: Mon, 13 Jul 2015 14:47:17 +0200 (CEST) From: Sebastian Ott X-X-Sender: sebott@denkbrett To: Jiang Liu cc: Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Grant Likely , Marc Zyngier , Stuart Yoder , Yijing Wang , Borislav Petkov , Gerald Schaefer , Martin Schwidefsky , Heiko Carstens , linux390@de.ibm.com, Tony Luck , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [RFC Patch V1 04/12] s390/pci: Use for_pci_msi_entry() to access MSI device list In-Reply-To: <1436428847-8886-5-git-send-email-jiang.liu@linux.intel.com> Message-ID: References: <1436428847-8886-1-git-send-email-jiang.liu@linux.intel.com> <1436428847-8886-5-git-send-email-jiang.liu@linux.intel.com> User-Agent: Alpine 2.11 (LFD 23 2013-08-11) Organization: =?ISO-8859-15?Q?=22IBM_Deutschland_Research_&_Development_GmbH_=2F_Vorsitzende_des_Aufsichtsrats=3A_Martina_Koederitz_Gesch=E4ftsf=FChrung=3A_Dirk_Wittkopp_Sitz_der_Gesellschaft=3A_B=F6blingen_=2F_Registergericht?= =?ISO-8859-15?Q?=3A_Amtsgericht_Stuttgart=2C_HRB_243294=22?= MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15071312-0017-0000-0000-000004B5FC6B Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1774 Lines: 57 On Thu, 9 Jul 2015, Jiang Liu wrote: > Use accessor for_pci_msi_entry() to access MSI device list, so we could > easily move msi_list from struct pci_dev into struct device later. > > Signed-off-by: Jiang Liu Acked-by: Sebastian Ott Regards, Sebastian > --- > arch/s390/pci/pci.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/s390/pci/pci.c b/arch/s390/pci/pci.c > index 598f023cf8a6..34f162753403 100644 > --- a/arch/s390/pci/pci.c > +++ b/arch/s390/pci/pci.c > @@ -414,7 +414,7 @@ int arch_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type) > > /* Request MSI interrupts */ > hwirq = 0; > - list_for_each_entry(msi, &pdev->msi_list, list) { > + for_each_pci_msi_entry(msi, pdev) { > rc = -EIO; > irq = irq_alloc_desc(0); /* Alloc irq on node 0 */ > if (irq < 0) > @@ -440,7 +440,7 @@ int arch_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type) > return (msi_vecs == nvec) ? 0 : msi_vecs; > > out_msi: > - list_for_each_entry(msi, &pdev->msi_list, list) { > + for_each_pci_msi_entry(msi, pdev) { > if (hwirq-- == 0) > break; > irq_set_msi_desc(msi->irq, NULL); > @@ -470,7 +470,7 @@ void arch_teardown_msi_irqs(struct pci_dev *pdev) > return; > > /* Release MSI interrupts */ > - list_for_each_entry(msi, &pdev->msi_list, list) { > + for_each_pci_msi_entry(msi, pdev) { > if (msi->msi_attrib.is_msix) > __pci_msix_desc_mask_irq(msi, 1); > else > -- > 1.7.10.4 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/