Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751608AbbGMNIp (ORCPT ); Mon, 13 Jul 2015 09:08:45 -0400 Received: from gum.cmpxchg.org ([85.214.110.215]:46742 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751037AbbGMNIo (ORCPT ); Mon, 13 Jul 2015 09:08:44 -0400 Date: Mon, 13 Jul 2015 09:08:12 -0400 From: Johannes Weiner To: "Kirill A. Shutemov" Cc: Andrew Morton , Oleg Nesterov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko Subject: Re: [PATCH 5/5] mm, memcontrol: use vma_is_anonymous() to check for anon VMA Message-ID: <20150713130812.GA8115@cmpxchg.org> References: <1436784852-144369-1-git-send-email-kirill.shutemov@linux.intel.com> <1436784852-144369-6-git-send-email-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436784852-144369-6-git-send-email-kirill.shutemov@linux.intel.com> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1338 Lines: 34 On Mon, Jul 13, 2015 at 01:54:12PM +0300, Kirill A. Shutemov wrote: > !vma->vm_file is not reliable to detect anon VMA, because not all > drivers bother set it. Let's use vma_is_anonymous() instead. > > Signed-off-by: Kirill A. Shutemov > Cc: Johannes Weiner > Cc: Michal Hocko > --- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index acb93c554f6e..a624709f0dd7 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -4809,7 +4809,7 @@ static struct page *mc_handle_file_pte(struct vm_area_struct *vma, > struct address_space *mapping; > pgoff_t pgoff; > > - if (!vma->vm_file) /* anonymous vma */ > + if (vma_is_anonymous(vma)) /* anonymous vma */ > return NULL; > if (!(mc.flags & MOVE_FILE)) > return NULL; The next line does vma->vm_file->f_mapping, so it had better be !NULL. It's not about reliably detecting anonymous vs. file, it is about whether there is a mapping against which we can do find_get_page(). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/