Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751947AbbGMNXp (ORCPT ); Mon, 13 Jul 2015 09:23:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52734 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751037AbbGMNXn (ORCPT ); Mon, 13 Jul 2015 09:23:43 -0400 From: Jeff Moyer To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox Subject: Re: [PATCH 06/10] mm: Add vmf_insert_pfn_pmd() References: <1436560165-8943-1-git-send-email-matthew.r.wilcox@intel.com> <1436560165-8943-7-git-send-email-matthew.r.wilcox@intel.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Mon, 13 Jul 2015 09:23:41 -0400 In-Reply-To: <1436560165-8943-7-git-send-email-matthew.r.wilcox@intel.com> (Matthew Wilcox's message of "Fri, 10 Jul 2015 16:29:21 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 937 Lines: 32 Matthew Wilcox writes: > +static int insert_pfn_pmd(struct vm_area_struct *vma, unsigned long addr, > + pmd_t *pmd, unsigned long pfn, pgprot_t prot, bool write) > +{ > + struct mm_struct *mm = vma->vm_mm; > + pmd_t entry; > + spinlock_t *ptl; > + > + ptl = pmd_lock(mm, pmd); > + if (pmd_none(*pmd)) { > + entry = pmd_mkhuge(pfn_pmd(pfn, prot)); > + if (write) { > + entry = pmd_mkyoung(pmd_mkdirty(entry)); > + entry = maybe_pmd_mkwrite(entry, vma); > + } > + set_pmd_at(mm, addr, pmd, entry); > + update_mmu_cache_pmd(vma, addr, pmd); > + } > + spin_unlock(ptl); > + return VM_FAULT_NOPAGE; > +} What's the point of the return value? Cheers, Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/