Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752307AbbGMOhK (ORCPT ); Mon, 13 Jul 2015 10:37:10 -0400 Received: from mail-ob0-f172.google.com ([209.85.214.172]:33103 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751615AbbGMOhI (ORCPT ); Mon, 13 Jul 2015 10:37:08 -0400 MIME-Version: 1.0 In-Reply-To: <1436447993-24630-1-git-send-email-k.kozlowski.k@gmail.com> References: <1436447993-24630-1-git-send-email-k.kozlowski.k@gmail.com> From: Alexandre Courbot Date: Mon, 13 Jul 2015 23:36:48 +0900 Message-ID: Subject: Re: [RFT PATCH] gpio: etraxfs: Fix devm_ioremap_resource return value check To: Krzysztof Kozlowski Cc: Linus Walleij , "linux-gpio@vger.kernel.org" , Linux Kernel Mailing List , Stable Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 627 Lines: 14 On Thu, Jul 9, 2015 at 10:19 PM, Krzysztof Kozlowski wrote: > Value returned by devm_ioremap_resource() was checked for non-NULL but > devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of > error this could lead to dereference of ERR_PTR. Look obvious enough to be merged without testing. Acked-by: Alexandre Courbot -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/