Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752157AbbGMPCk (ORCPT ); Mon, 13 Jul 2015 11:02:40 -0400 Received: from mail-ie0-f171.google.com ([209.85.223.171]:33100 "EHLO mail-ie0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751530AbbGMPCh (ORCPT ); Mon, 13 Jul 2015 11:02:37 -0400 MIME-Version: 1.0 In-Reply-To: <20150713132025.GA4071@salvia> References: <20150710001501.GA32570@dtor-ws> <20150713132025.GA4071@salvia> Date: Mon, 13 Jul 2015 08:02:36 -0700 Message-ID: Subject: Re: [PATCH] nf: IDLETIMER: fix lockdep warning From: Dmitry Torokhov To: Pablo Neira Ayuso Cc: "David S. Miller" , Patrick McHardy , Jozsef Kadlecsik , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2730 Lines: 53 On Mon, Jul 13, 2015 at 6:20 AM, Pablo Neira Ayuso wrote: > On Thu, Jul 09, 2015 at 05:15:01PM -0700, Dmitry Torokhov wrote: >> Dynamically allocated sysfs attributes should be initialized with >> sysfs_attr_init() otherwise lockdep will be angry with us: >> >> [ 45.468653] BUG: key ffffffc030fad4e0 not in .data! >> [ 45.468655] ------------[ cut here ]------------ >> [ 45.468666] WARNING: CPU: 0 PID: 1176 at /mnt/host/source/src/third_party/kernel/v3.18/kernel/locking/lockdep.c:2991 lockdep_init_map+0x12c/0x490() >> [ 45.468672] DEBUG_LOCKS_WARN_ON(1) >> [ 45.468672] CPU: 0 PID: 1176 Comm: iptables Tainted: G U W 3.18.0 #43 >> [ 45.468674] Hardware name: XXX >> [ 45.468675] Call trace: >> [ 45.468680] [] dump_backtrace+0x0/0x10c >> [ 45.468683] [] show_stack+0x10/0x1c >> [ 45.468688] [] dump_stack+0x74/0x94 >> [ 45.468692] [] warn_slowpath_common+0x84/0xb0 >> [ 45.468694] [] warn_slowpath_fmt+0x4c/0x58 >> [ 45.468697] [] lockdep_init_map+0x128/0x490 >> [ 45.468701] [] __kernfs_create_file+0x80/0xe4 >> [ 45.468704] [] sysfs_add_file_mode_ns+0x104/0x170 >> [ 45.468706] [] sysfs_create_file_ns+0x58/0x64 >> [ 45.468711] [] idletimer_tg_checkentry+0x14c/0x324 >> [ 45.468714] [] xt_check_target+0x170/0x198 >> [ 45.468717] [] check_target+0x58/0x6c >> [ 45.468720] [] translate_table+0x30c/0x424 >> [ 45.468723] [] do_ipt_set_ctl+0x144/0x1d0 >> [ 45.468728] [] nf_setsockopt+0x50/0x60 >> [ 45.468732] [] ip_setsockopt+0x8c/0xb4 >> [ 45.468735] [] raw_setsockopt+0x10/0x50 >> [ 45.468739] [] sock_common_setsockopt+0x14/0x20 >> [ 45.468742] [] SyS_setsockopt+0x88/0xb8 >> [ 45.468744] ---[ end trace 41d156354d18c039 ]--- > > Applied, thanks. > > One question: > >> Change-Id: I1da5cd96fc8e1e1e4209e81eba1165a42d4d45e9 > > BTW, does this gerrit change ID provide any public information? Thanks. Argh, I am sorry, I forgot to clean this out when mailing the patch. In this particular case you can find the change in AOSP gerrit at https://android-review.googlesource.com but without such context this change-id is of course useless. Thanks, Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/