Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752032AbbGMPLp (ORCPT ); Mon, 13 Jul 2015 11:11:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33101 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751284AbbGMPLm (ORCPT ); Mon, 13 Jul 2015 11:11:42 -0400 Date: Mon, 13 Jul 2015 18:11:38 +0300 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: Bjorn Helgaas , Rajat Jain , "Chen, Gong" , Guenter Roeck , =?us-ascii?B?PT9VVEYtOD9xP1JhZmE9QzU9ODI9MjBNaT1DNT04MmVja2k/PQ==?= , linux-api@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH] pci_regs: reintroduce PCI_MSIX_FLAGS_BIRMASK Message-ID: <20150713181025-mutt-send-email-mst@redhat.com> References: <1435745608-21217-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435745608-21217-1-git-send-email-mst@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1570 Lines: 39 On Wed, Jul 01, 2015 at 12:14:10PM +0200, Michael S. Tsirkin wrote: > This partially reverts commit 09a2c73ddfc7f173237fc7209a65b34dd5bcb5ed. > PCI: Remove unused PCI_MSIX_FLAGS_BIRMASK definition > > That commit dropped a symbol from an exported header claiming "no one > uses it". This isn't how Linux normally approaches userspace API though, > and in fact QEMU build fails if trying to use updated headers from linux > 3.12 and up. > > Sure, userspace can be fixed to use the new symbol, but the cost > of keeping the old one around is fairly low, too. > > Signed-off-by: Michael S. Tsirkin Ping. Can this be included upstream please? > --- > include/uapi/linux/pci_regs.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h > index efe3443..66644ac 100644 > --- a/include/uapi/linux/pci_regs.h > +++ b/include/uapi/linux/pci_regs.h > @@ -319,6 +319,7 @@ > #define PCI_MSIX_PBA 8 /* Pending Bit Array offset */ > #define PCI_MSIX_PBA_BIR 0x00000007 /* BAR index */ > #define PCI_MSIX_PBA_OFFSET 0xfffffff8 /* Offset into specified BAR */ > +#define PCI_MSIX_FLAGS_BIRMASK PCI_MSIX_PBA_BIR /* deprecated */ > #define PCI_CAP_MSIX_SIZEOF 12 /* size of MSIX registers */ > > /* MSI-X Table entry format */ > -- > MST -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/