Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751989AbbGMPWW (ORCPT ); Mon, 13 Jul 2015 11:22:22 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:34932 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751596AbbGMPWS (ORCPT ); Mon, 13 Jul 2015 11:22:18 -0400 Message-ID: <55A3D7A3.90609@linaro.org> Date: Mon, 13 Jul 2015 23:22:11 +0800 From: Hanjun Guo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Lukasz Anaczkowski , tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, jason@lakedaemon.net CC: rjw@rjwysocki.net, len.brown@intel.com, pavel@ucw.cz, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH] x86, acpi: Handle xapic/x2apic entries in MADT References: <1436795687-18539-1-git-send-email-lukasz.anaczkowski@intel.com> In-Reply-To: <1436795687-18539-1-git-send-email-lukasz.anaczkowski@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1436 Lines: 38 Hi Lukasz, On 07/13/2015 09:54 PM, Lukasz Anaczkowski wrote: > This patch is based on work of "Yinghai Lu " > previously published at https://lkml.org/lkml/2013/1/21/563. > > In case when BIOS is populating MADT wiht both x2apic and local apic > entries (as per ACPI spec), kernel builds it's processor table > in the following order: BSP, X2APIC, local APIC, resulting in > processors on the same core are not separated by core count. I'm confused here, I can't figure out where is the problem, could you explain it in detail? For me, logical CPU IDs allocated by OS will have mappings to physical CPU IDs, what you are saying seems CPU topology problem to me. > > This patch fixes this behavior and resulting assignment is > correct. > > Signed-off-by: Lukasz Anaczkowski > --- > arch/x86/kernel/acpi/boot.c | 29 +++++++++++++----- > drivers/acpi/numa.c | 28 ++++++++++++----- > drivers/acpi/tables.c | 75 ++++++++++++++++++++++++++++----------------- > drivers/irqchip/irq-gic.c | 15 ++++++--- Anyway, You also miss the SMP boot for ARM64 in ACPI way, which will cause compile error on ARM64. Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/