Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752091AbbGMRBn (ORCPT ); Mon, 13 Jul 2015 13:01:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39779 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751149AbbGMRBm (ORCPT ); Mon, 13 Jul 2015 13:01:42 -0400 Message-ID: <55A3EEF3.9080106@redhat.com> Date: Mon, 13 Jul 2015 19:01:39 +0200 From: Milan Broz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Joseph Salisbury CC: Mike Snitzer , "Martin K. Petersen" , linux-kernel@vger.kernel.org, JBottomley@Parallels.com, Kernel Team , jgarzik@redhat.com Subject: Re: [PATCH] dm-crypt: never use write same (was Re: [v3.7 Regression] [SCSI] sd: Implement support for WRITE SAME) References: <50CB8C74.3090102@canonical.com> <50D0C971.1000907@canonical.com> <20121219195801.GA14456@redhat.com> <50D22766.9090107@redhat.com> <50D22C7F.2020201@redhat.com> <50D23DA3.9060104@canonical.com> <55A3E843.9080209@canonical.com> In-Reply-To: <55A3E843.9080209@canonical.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1028 Lines: 27 (sorry, resending again, not sure if it was sent correctly) On 07/13/2015 06:33 PM, Joseph Salisbury wrote: > Hi Milan, > > The Ubuntu kernel has been carrying this patch since the discussion[0] > we were having about the bug. I don't see that patch was ever included > in mainline. Do you happen to know if this patch is still needed or was > the bug we were seeing fixed in some other way? I think it was superseded by later Mike's approach to reverse the logic - disable write same for all targets and require to explicitly allow it. http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/md/dm-table.c?id=c1a94672a830e01d58c7c7e8de530c3f136d6ff2 (+later patches) So I think we do no need this patch upstream anymore. Mike, am I right here? Milan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/