Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752214AbbGMRHB (ORCPT ); Mon, 13 Jul 2015 13:07:01 -0400 Received: from mga14.intel.com ([192.55.52.115]:16688 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751971AbbGMRHA (ORCPT ); Mon, 13 Jul 2015 13:07:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,463,1432623600"; d="scan'208";a="605340083" Message-ID: <55A3EFE9.7080101@linux.intel.com> Date: Mon, 13 Jul 2015 10:05:45 -0700 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Oleg Nesterov , "Kirill A. Shutemov" CC: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andy Lutomirski , Thomas Gleixner Subject: Re: [PATCH 2/5] x86, mpx: do not set ->vm_ops on mpx VMAs References: <1436784852-144369-1-git-send-email-kirill.shutemov@linux.intel.com> <1436784852-144369-3-git-send-email-kirill.shutemov@linux.intel.com> <20150713165323.GA7906@redhat.com> In-Reply-To: <20150713165323.GA7906@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 838 Lines: 22 On 07/13/2015 09:53 AM, Oleg Nesterov wrote: > On 07/13, Kirill A. Shutemov wrote: >> >> We don't really need ->vm_ops here: MPX VMA can be detected with VM_MPX >> flag. And vma_merge() will not merge MPX VMA with non-MPX VMA, because >> ->vm_flags won't match. > > Agreed. > > I am wondering if something like the patch below (on top of yours) makes > sense... Not sure, but mpx_mmap() doesn't look nice too, and with this > change we can unexport mmap_region(). These both look nice to me (and they both cull specialty MPX code which is excellent). I'll run them through a quick test. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/