Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752066AbbGMRhs (ORCPT ); Mon, 13 Jul 2015 13:37:48 -0400 Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:33413 "EHLO mail-gw3-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751451AbbGMRhp (ORCPT ); Mon, 13 Jul 2015 13:37:45 -0400 X-IronPort-AV: E=Sophos;i="5.15,464,1432623600"; d="scan'208";a="69541654" Message-ID: <55A3F6FD.1070006@broadcom.com> Date: Mon, 13 Jul 2015 10:35:57 -0700 From: Florian Fainelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Linus Walleij , Gregory Fong , Grant Likely , "Bjorn Helgaas" , Rob Herring CC: "linux-gpio@vger.kernel.org" , "Alexandre Courbot" , bcm-kernel-feedback-list , Brian Norris , "devicetree@vger.kernel.org" , Florian Fainelli , "Ian Campbell" , Kumar Gala , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Mark Rutland , "Pawel Moll" , Russell King Subject: Re: [PATCH v3 2/4] dt-bindings: brcmstb-gpio: document properties for wakeup References: <1434589243-502-1-git-send-email-gregory.0xf0@gmail.com> <1434589243-502-3-git-send-email-gregory.0xf0@gmail.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2064 Lines: 56 On 13/07/15 05:29, Linus Walleij wrote: > On Thu, Jun 18, 2015 at 3:00 AM, Gregory Fong wrote: > >> Some brcmstb GPIO controllers can be used to wake from suspend, so use >> the de facto standard property 'wakeup-source' to mark the nodes of >> controllers with that capability. >> >> Also document interrupts-extended, which will be used for wakeup >> handling because the interrupt parent for the wake IRQ is different >> from the regular IRQ. >> >> While we're at it, a few more fixes: We don't actually use the >> "interrupt-names" property, so remove it from the listed optional >> properties and from the examples. And since we're modifying the >> examples, also follow Brian's suggestions to: >> - change #gpio-cells, #interrupt-cells, and brcm,gpio-bank-widths from >> hex to dec >> - use phandles >> >> Reviewed-by: Brian Norris >> Signed-off-by: Gregory Fong >> --- >> v3: Update per Brian's suggestions described in above message. > > I'm very uncertain regarding these interrupts-extended etc. Gregory's additions to the binding are correct and comply with how the 'interrupts-extended' property is meant to be used. FYI, this is required because most wake-up capable HW on brcmstb chips have N interrupts feeding to a GIC, but their wake-up interrupt(s) feed to an always-on interrupt controller. With the 'interrupts' + 'interrupt-parent' property, you can "cross" multiple interrupt domains. The precedence and rules for interpreting the "legacy" interrupts property vs. interrupts-extended is documented in the tree. > > Can someone who understands that ACK this? Acked-by: Florian Fainelli > > E.g. Grant Likely, Björn Helgaas, Rob Herring. > > Yours, > Linus Walleij > -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/