Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752351AbbGMSfg (ORCPT ); Mon, 13 Jul 2015 14:35:36 -0400 Received: from mail-wg0-f53.google.com ([74.125.82.53]:35148 "EHLO mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752169AbbGMSfb (ORCPT ); Mon, 13 Jul 2015 14:35:31 -0400 MIME-Version: 1.0 In-Reply-To: <20150713032303.D49801402B1@ozlabs.org> References: <20150712220211.7166.42035.stgit@bhelgaas-glaptop2.roam.corp.google.com> <20150713032303.D49801402B1@ozlabs.org> From: Bjorn Helgaas Date: Mon, 13 Jul 2015 13:35:09 -0500 Message-ID: Subject: Re: [3/3] IRQ: Print "unexpected IRQ" messages consistently across architectures To: Michael Ellerman Cc: Thomas Gleixner , Linux-Arch , "linux-mips@linux-mips.org" , linux-am33-list@redhat.com, "linux-ia64@vger.kernel.org" , linux-c6x-dev@linux-c6x.org, linux-parisc@vger.kernel.org, "linux-s390@vger.kernel.org" , "linux-sh@vger.kernel.org" , adi-buildroot-devel@lists.sourceforge.net, "linux-kernel@vger.kernel.org" , linux-m68k@vger.kernel.org, linux-alpha@vger.kernel.org, "x86@kernel.org" , linuxppc-dev Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1761 Lines: 47 On Sun, Jul 12, 2015 at 10:23 PM, Michael Ellerman wrote: > On Sun, 2015-12-07 at 22:02:11 UTC, Bjorn Helgaas wrote: >> Many architectures use a variant of "unexpected IRQ trap at vector %x" to >> log unexpected IRQs. This is confusing because (a) it prints the Linux IRQ >> number, but "vector" more often refers to a CPU vector number, and (b) it >> prints the IRQ number in hex with no base indication, while Linux IRQ >> numbers are usually printed in decimal. >> >> Print the same text ("unexpected IRQ %d") across all architectures. >> >> No functional change other than the output text. > > There's already a fallback version in asm-generic, so shouldn't you instead > just delete all the versions that are identical to that? > > eg. on powerpc we have: > >> static inline void ack_bad_irq(unsigned int irq) >> { >> - printk(KERN_CRIT "unexpected IRQ trap at vector %02x\n", irq); >> + printk(KERN_CRIT "unexpected IRQ %d\n", irq); >> } > > And the generic version is: > >> #ifndef ack_bad_irq >> static inline void ack_bad_irq(unsigned int irq) >> { >> - printk(KERN_CRIT "unexpected IRQ trap at vector %02x\n", irq); >> + printk(KERN_CRIT "unexpected IRQ %d\n", irq); >> } >> #endif > > So we can just delete the powerpc version? Wow, I really didn't do my homework here. Not only is there a generic version already, but there's also print_irq_desc(), which prints way more information than any of the ack_bad_irq() implementations. I'll try again :) Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/