Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753678AbbGMUmJ (ORCPT ); Mon, 13 Jul 2015 16:42:09 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34500 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753653AbbGMUmE (ORCPT ); Mon, 13 Jul 2015 16:42:04 -0400 Message-ID: <55A42299.3040809@codeaurora.org> Date: Mon, 13 Jul 2015 13:42:01 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Krzysztof Kozlowski CC: Mike Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Chanwoo Choi , Sylwester Nawrocki Subject: Re: [PATCH 22/45] clk: samsung: Properly include clk.h and clkdev.h References: <1436571223-10959-1-git-send-email-sboyd@codeaurora.org> <1436571223-10959-23-git-send-email-sboyd@codeaurora.org> <55A0C0A6.8060600@samsung.com> In-Reply-To: <55A0C0A6.8060600@samsung.com> Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1670 Lines: 50 On 07/11/2015 12:07 AM, Krzysztof Kozlowski wrote: > W dniu 11.07.2015 o 08:33, Stephen Boyd pisze: > >> diff --git a/drivers/clk/samsung/clk.c b/drivers/clk/samsung/clk.c >> index 0117238391d6..f38a6c49f744 100644 >> --- a/drivers/clk/samsung/clk.c >> +++ b/drivers/clk/samsung/clk.c >> @@ -11,6 +11,10 @@ >> * clock framework for Samsung platforms. >> */ >> >> +#include >> +#include >> +#include >> +#include >> #include >> #include >> >> diff --git a/drivers/clk/samsung/clk.h b/drivers/clk/samsung/clk.h >> index b775fc29caa5..aa872d2c5105 100644 >> --- a/drivers/clk/samsung/clk.h >> +++ b/drivers/clk/samsung/clk.h >> @@ -13,10 +13,11 @@ >> #ifndef __SAMSUNG_CLK_H >> #define __SAMSUNG_CLK_H >> >> -#include >> #include >> #include "clk-pll.h" >> >> +struct clk; >> + > Hmmm... why? Including clk-provider (which declares struct clk in your > last patch) is not sufficient? > I hope to eventually remove the forward declaration of struct clk in clk-provider.h too. That will take some more time though. I can leave this part out of the patch if you like and add it back when that work is done, it doesn't matter to me. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/