Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752043AbbGMVlY (ORCPT ); Mon, 13 Jul 2015 17:41:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33772 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751117AbbGMVlX (ORCPT ); Mon, 13 Jul 2015 17:41:23 -0400 Date: Mon, 13 Jul 2015 23:41:18 +0200 From: Igor Mammedov To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, pbonzini@redhat.com Subject: Re: [PATCH] vhost: fix build failure on SPARC Message-ID: <20150713234118.1781495a@igors-macbook-pro.local> In-Reply-To: <20150713231850-mutt-send-email-mst@redhat.com> References: <1435842491-131872-2-git-send-email-imammedo@redhat.com> <1436811330-273019-1-git-send-email-imammedo@redhat.com> <20150713231850-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1567 Lines: 50 On Mon, 13 Jul 2015 23:19:59 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jul 13, 2015 at 08:15:30PM +0200, Igor Mammedov wrote: > > while on x86 target vmalloc.h is included indirectly through > > other heaedrs, it's not included on SPARC. > > Fix issue by including vmalloc.h directly from vhost.c > > like it's done in vhost/net.c > > > > Signed-off-by: Igor Mammedov > > It's your vmalloc patch that introduces the issue, right? > I squashed this fix into that one. Thanks! yep, that right. I've sent this patch as reply to vmalloc patch that introduced issue but forgot to add commit it that introduced issue. > > You can just send fixup! patches in cases like this > in the future, or at least mention the commit that > breaks the build. ok, I'll do it next time. > > > > --- > > drivers/vhost/vhost.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > > index 9a68e2e..a9fe859 100644 > > --- a/drivers/vhost/vhost.c > > +++ b/drivers/vhost/vhost.c > > @@ -22,6 +22,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > -- > > 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/