Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752880AbbGMXAG (ORCPT ); Mon, 13 Jul 2015 19:00:06 -0400 Received: from seldrel01.sonyericsson.com ([37.139.156.2]:13681 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752590AbbGMXAE (ORCPT ); Mon, 13 Jul 2015 19:00:04 -0400 Date: Mon, 13 Jul 2015 15:59:57 -0700 From: Bjorn Andersson To: Stephen Boyd , Linus Walleij CC: , , , , Pramod Gurav Subject: Re: [PATCH] pinctrl: qcom: Hook pm_power_down for shutdown support Message-ID: <20150713225957.GF15178@usrtlx11787.corpusers.net> References: <1436231370-18301-1-git-send-email-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1436231370-18301-1-git-send-email-sboyd@codeaurora.org> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1100 Lines: 27 On Mon 06 Jul 18:09 PDT 2015, Stephen Boyd wrote: > Assign pm_power_off() if we have the PS_HOLD functionality so > that we can properly shutdown the SoC. Otherwise, shutdown won't > do anything besides put the CPU into a tight loop. Unfortunately, > we have to use a singleton here because pm_power_off() doesn't > take any arguments. Fortunately there's only one instance of the > pinctrl device on a running system so this isn't a problem. > > Cc: Bjorn Andersson > Cc: Pramod Gurav > Signed-off-by: Stephen Boyd I do find it odd that there's generic handling for restart but only the crude way pm_power_off to shut the system down... But this seems to be the way it should be done... Acked-by: Bjorn Andersson Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/