Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753202AbbGNCiR (ORCPT ); Mon, 13 Jul 2015 22:38:17 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40736 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752722AbbGNCiP (ORCPT ); Mon, 13 Jul 2015 22:38:15 -0400 Date: Mon, 13 Jul 2015 19:38:14 -0700 From: Greg Kroah-Hartman To: Luis de Bethencourt Cc: linux-kernel@vger.kernel.org, Oleg Drokin , Andreas Dilger , "John L. Hammond" , Ryan Haasken , Heena Sirwani , Hatice =?iso-8859-1?Q?ERT=DCRK?= , Joe Perches , Supriya Karanth , Julia Lawall , Bobi Jam , HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org Subject: Re: [PATCH] staging: lustre: mgc: no need to compare bool value Message-ID: <20150714023814.GA11616@kroah.com> References: <20150623142611.GA5816@goodgumbo.baconseed.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150623142611.GA5816@goodgumbo.baconseed.org> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 580 Lines: 15 On Tue, Jun 23, 2015 at 04:26:11PM +0200, Luis de Bethencourt wrote: > Inverting the value of eof is a more direct way of passing to the debugging > function if eof is false or not. Really? I like the explicit-ness of the code as it is today, it's more obvious what is going on, which is the most important thing. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/