Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753340AbbGNCnR (ORCPT ); Mon, 13 Jul 2015 22:43:17 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40760 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751931AbbGNCnO (ORCPT ); Mon, 13 Jul 2015 22:43:14 -0400 Date: Mon, 13 Jul 2015 19:43:13 -0700 From: Greg Kroah-Hartman To: Dan Carpenter Cc: green@linuxhacker.ru, devel@driverdev.osuosl.org, Andreas Dilger , Linux Kernel Mailing List Subject: Re: [PATCH 18/20] staging/lustre/libcfs: get rid of debugfs/lnet/debug_mb Message-ID: <20150714024313.GA24722@kroah.com> References: <1436201338-14263-1-git-send-email-green@linuxhacker.ru> <1436201338-14263-19-git-send-email-green@linuxhacker.ru> <20150708084202.GN4341@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150708084202.GN4341@mwanda> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 849 Lines: 27 On Wed, Jul 08, 2015 at 11:45:59AM +0300, Dan Carpenter wrote: > On Mon, Jul 06, 2015 at 12:48:56PM -0400, green@linuxhacker.ru wrote: > > +static int libcfs_param_debug_mb_set(const char *val, > > + const struct kernel_param *kp) > > +{ > > + int rc; > > + unsigned num; > > + > > + rc = kstrtouint(val, 0, &num); > > + if (rc == -EINVAL) > > + return -EINVAL; > > Presumably, this is root only so using num uninitialized is not an > information leak. But it's not good, this should be a check for rc < 0 to make sure. Oleg, can you send a follow-on patch to fix this up? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/