From: Kukjin Kim <kgene@kernel.org>
To: "'Krzysztof Kozlowski'" <k.kozlowski@samsung.com>,
        "'Javier Martinez Canillas'" <javier@osg.samsung.com>,
        "'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>
Cc: linux-samsung-soc@vger.kernel.org, "'Arnd Bergmann'" <arnd@arndb.de>,
        linux-kernel@vger.kernel.org, "'Kukjin Kim'" <kgene@kernel.org>,
        linux-serial@vger.kernel.org, "'Jiri Slaby'" <jslaby@suse.cz>,
        linux-arm-kernel@lists.infradead.org
References: <1436786331-5188-1-git-send-email-javier@osg.samsung.com>
 <55A46C4F.8050803@samsung.com>
In-reply-to: <55A46C4F.8050803@samsung.com>
Subject: RE: [PATCH] serial: samsung: Remove redundant DEBUG_LL check
Date: Tue, 14 Jul 2015 13:41:29 +0900
Message-id: <069e01d0bdef$59a73c70$0cf5b550$@kernel.org>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
Thread-index: AQH+TqxyXQ+bcLwBuTfy8zRcD2HSiwE9/qACnXVRMKA=
Content-language: ko
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1076
Lines: 34

Krzysztof Kozlowski wrote:
> 
> On 13.07.2015 20:18, Javier Martinez Canillas wrote:
> > Commit 84f57d9e3685 ("tty: serial/samsung: fix modular build") fixed
> > build issues when the driver was built as a module. One of those was
> > that printascii is only accessible when the driver is built-in.
> >
> > But there is no need to check for defined(CONFIG_DEBUG_LL) since the
> > SERIAL_SAMSUNG_DEBUG Kconfig symbol already depends on DEBUG_LL.
> >
> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Acked-by: Kukjin Kim <kgene@kernel.org>

Thanks,
Kukjin

> >
> > ---
> >
> >  drivers/tty/serial/samsung.c | 1 -
> >  1 file changed, 1 deletion(-)
> 
> Although this redundancy is not harmful the patch seems fine, so:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> Best regards,
> Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/