Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752999AbbGNGzX (ORCPT <rfc822;w@1wt.eu>);
	Tue, 14 Jul 2015 02:55:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49994 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752942AbbGNGzV (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 14 Jul 2015 02:55:21 -0400
Date: Tue, 14 Jul 2015 08:55:18 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: kan.liang@intel.com
Cc: acme@kernel.org, jolsa@kernel.org, namhyung@kernel.org, ak@linux.intel.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC V3 2/5] perf/documentation: Add description for period
Message-ID: <20150714065518.GH22977@krava.local>
References: <1436345097-11113-1-git-send-email-kan.liang@intel.com>
 <1436345097-11113-3-git-send-email-kan.liang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1436345097-11113-3-git-send-email-kan.liang@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1695
Lines: 46

On Wed, Jul 08, 2015 at 04:44:54AM -0400, kan.liang@intel.com wrote:
> From: Kan Liang <kan.liang@intel.com>
> 
> 'period' param is not defined in
> /sys/bus/event_sources/devices/<pmu>/format/*
> 
> Signed-off-by: Kan Liang <kan.liang@intel.com>
> ---
>  tools/perf/Documentation/perf-record.txt | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
> index 9b9d9d0..5b47b2c 100644
> --- a/tools/perf/Documentation/perf-record.txt
> +++ b/tools/perf/Documentation/perf-record.txt
> @@ -45,6 +45,14 @@ OPTIONS
>            param1 and param2 are defined as formats for the PMU in:
>            /sys/bus/event_sources/devices/<pmu>/format/*
>  
> +	  There are also some params which are not defined in .../<pmu>/format/*.
> +	  These params can be used to set event defaults.
> +	  Here is a list of the params.
> +	  - 'period': Set event sampling period

Acked-by: Jiri Olsa <jolsa@kernel.org>

while at it, could you please add doc also for 'name'?

thanks,
jirka

> +
> +	  Note: If user explicitly sets options which conflict with the params,
> +	  the value set by the params will be overridden.
> +
>          - a hardware breakpoint event in the form of '\mem:addr[/len][:access]'
>            where addr is the address in memory you want to break in.
>            Access is the memory access type (read, write, execute) it can
> -- 
> 1.8.3.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/