Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752812AbbGNGzH (ORCPT ); Tue, 14 Jul 2015 02:55:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32884 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751018AbbGNGzE (ORCPT ); Tue, 14 Jul 2015 02:55:04 -0400 From: Minfei Huang To: akpm@linux-foundation.org, rob.jones@codethink.co.uk, amhyung@kernel.org, rusty@rustcorp.com.au Cc: linux-kernel@vger.kernel.org, Minfei Huang Subject: [PATCH 1/2] Define find_symbol_in_section_t as function type to simplify the code Date: Tue, 14 Jul 2015 14:59:12 +0800 Message-Id: <1436857153-18874-2-git-send-email-mhuang@redhat.com> In-Reply-To: <1436857153-18874-1-git-send-email-mhuang@redhat.com> References: <1436857153-18874-1-git-send-email-mhuang@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2702 Lines: 78 From: Minfei Huang It is not elegance, if we use function directly as the argument, like following: bool each_symbol_section(bool (*fn)(const struct symsearch *arr, struct module *owner, void *data), void *data); Here introduce a type defined function find_symbol_in_section_t. Now we can use these type defined function directly, if we want to pass the function as the argument. bool each_symbol_section(find_symbol_in_section_t fn, void *data); Signed-off-by: Minfei Huang --- include/linux/module.h | 6 +++--- kernel/module.c | 9 ++------- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/include/linux/module.h b/include/linux/module.h index d67b193..1e125b1 100644 --- a/include/linux/module.h +++ b/include/linux/module.h @@ -462,14 +462,14 @@ const struct kernel_symbol *find_symbol(const char *name, bool gplok, bool warn); +typedef bool (*find_symbol_in_section_t)(const struct symsearch *arr, + struct module *owner, void *data); /* * Walk the exported symbol table * * Must be called with module_mutex held or preemption disabled. */ -bool each_symbol_section(bool (*fn)(const struct symsearch *arr, - struct module *owner, - void *data), void *data); +bool each_symbol_section(find_symbol_in_section_t fn, void *data); /* Returns 0 and fills in value, defined and namebuf, or -ERANGE if symnum out of range. */ diff --git a/kernel/module.c b/kernel/module.c index 4d2b82e..1400c0b 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -426,9 +426,7 @@ extern const unsigned long __start___kcrctab_unused_gpl[]; static bool each_symbol_in_section(const struct symsearch *arr, unsigned int arrsize, struct module *owner, - bool (*fn)(const struct symsearch *syms, - struct module *owner, - void *data), + find_symbol_in_section_t fn, void *data) { unsigned int j; @@ -442,10 +440,7 @@ static bool each_symbol_in_section(const struct symsearch *arr, } /* Returns true as soon as fn returns true, otherwise false. */ -bool each_symbol_section(bool (*fn)(const struct symsearch *arr, - struct module *owner, - void *data), - void *data) +bool each_symbol_section(find_symbol_in_section_t fn, void *data) { struct module *mod; static const struct symsearch arr[] = { -- 2.2.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/