Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753475AbbGNHkN (ORCPT ); Tue, 14 Jul 2015 03:40:13 -0400 Received: from mail-yk0-f178.google.com ([209.85.160.178]:35003 "EHLO mail-yk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752963AbbGNHkH (ORCPT ); Tue, 14 Jul 2015 03:40:07 -0400 MIME-Version: 1.0 In-Reply-To: <1436779969-18610-2-git-send-email-yingjoe.chen@mediatek.com> References: <1436779969-18610-1-git-send-email-yingjoe.chen@mediatek.com> <1436779969-18610-2-git-send-email-yingjoe.chen@mediatek.com> From: Daniel Kurtz Date: Tue, 14 Jul 2015 15:39:47 +0800 X-Google-Sender-Auth: rvF4GHZ1Gvbva3xhW1iFh9gnxtc Message-ID: Subject: Re: [PATCH 1/5] clocksource: mediatek: do not enable GPT_CLK_EVT when setup To: Yingjoe Chen Cc: Matthias Brugger , Thomas Gleixner , Stephen Boyd , Michael Turquette , James Liao , Russell King , "open list:OPEN FIRMWARE AND..." , Arnd Bergmann , Catalin Marinas , Daniel Lezcano , "linux-kernel@vger.kernel.org" , Rob Herring , linux-mediatek@lists.infradead.org, Sascha Hauer , Olof Johansson , srv_heupstream , "linux-arm-kernel@lists.infradead.org" , linux-clk@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3198 Lines: 83 Hi Yingjoe, On Mon, Jul 13, 2015 at 5:32 PM, Yingjoe Chen wrote: > Spurious mtk timer interrupt is noticed at boot and cause kernel > crash. It seems if GPT is enabled, it will latch irq status even > when its IRQ is disabled. When irq is enabled afterward, we see > spurious interrupt. > Change init flow to only enable GPT_CLK_SRC at mtk_timer_init. > > Signed-off-by: Yingjoe Chen > --- > drivers/clocksource/mtk_timer.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c > index 68ab423..237c20b 100644 > --- a/drivers/clocksource/mtk_timer.c > +++ b/drivers/clocksource/mtk_timer.c > @@ -156,9 +156,11 @@ static void mtk_timer_global_reset(struct mtk_clock_event_device *evt) > writel(0x3f, evt->gpt_base + GPT_IRQ_ACK_REG); > } > > -static void > -mtk_timer_setup(struct mtk_clock_event_device *evt, u8 timer, u8 option) > +static void mtk_timer_setup(struct mtk_clock_event_device *evt, u8 timer, > + u8 option, bool enable) This function can be: __init Other than this tiny nit, and the small potential conflict in patch 4, this whole series is: Reviewed-by: Daniel Kurtz (I do think it is a bit strange that the mediatek,mt6577-timer binding does not use "clock-names", but that is independent of this patch set). Thanks! > { > + u32 val; > + > writel(TIMER_CTRL_CLEAR | TIMER_CTRL_DISABLE, > evt->gpt_base + TIMER_CTRL_REG(timer)); > > @@ -167,8 +169,10 @@ mtk_timer_setup(struct mtk_clock_event_device *evt, u8 timer, u8 option) > > writel(0x0, evt->gpt_base + TIMER_CMP_REG(timer)); > > - writel(TIMER_CTRL_OP(option) | TIMER_CTRL_ENABLE, > - evt->gpt_base + TIMER_CTRL_REG(timer)); > + val = TIMER_CTRL_OP(option); > + if (enable) > + val |= TIMER_CTRL_ENABLE; > + writel(val, evt->gpt_base + TIMER_CTRL_REG(timer)); > } > > static void mtk_timer_enable_irq(struct mtk_clock_event_device *evt, u8 timer) > @@ -235,12 +239,12 @@ static void __init mtk_timer_init(struct device_node *node) > evt->ticks_per_jiffy = DIV_ROUND_UP(rate, HZ); > > /* Configure clock source */ > - mtk_timer_setup(evt, GPT_CLK_SRC, TIMER_CTRL_OP_FREERUN); > + mtk_timer_setup(evt, GPT_CLK_SRC, TIMER_CTRL_OP_FREERUN, true); > clocksource_mmio_init(evt->gpt_base + TIMER_CNT_REG(GPT_CLK_SRC), > node->name, rate, 300, 32, clocksource_mmio_readl_up); > > /* Configure clock event */ > - mtk_timer_setup(evt, GPT_CLK_EVT, TIMER_CTRL_OP_REPEAT); > + mtk_timer_setup(evt, GPT_CLK_EVT, TIMER_CTRL_OP_REPEAT, false); > clockevents_config_and_register(&evt->dev, rate, 0x3, > 0xffffffff); > > -- > 1.8.1.1.dirty > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/