Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753067AbbGNIXo (ORCPT ); Tue, 14 Jul 2015 04:23:44 -0400 Received: from mail-bn1bon0138.outbound.protection.outlook.com ([157.56.111.138]:36016 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751830AbbGNIXi (ORCPT ); Tue, 14 Jul 2015 04:23:38 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=amd.com; gmail.com; dkim=none (message not signed) header.d=none; X-WSS-ID: 0NRGXZ6-08-CHA-02 X-M-MSG: Message-ID: <55A4C702.9070005@amd.com> Date: Tue, 14 Jul 2015 10:23:30 +0200 From: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Alexander Kuleshov , Alex Deucher CC: David Airlie , Alex Deucher , Jammy Zhou , yanyang1 , =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , Maninder Singh , LKML , "Maling list - DRI developers" Subject: Re: [PATCH] gpu/drm/amdgpu: Include only if CONFIG_DEBUG_FS is set References: <1436785437-3457-1-git-send-email-kuleshovmail@gmail.com> In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.224.49.64] X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD011;1:QKePWR4k0XQyNlnkWGlULE+oC7YBNHCqiWIRS7a8WuBjDcpusf8iT53rImHdigAX+JmS/S5LL39Y9be5n8tENoni6jRpoOox4utUCGrh33sbS9fQKOtzXwfSublJFLWqmGeHN0I9ndmjWB1M8rXolX0bwvYmrZuSK5H1zrxpPrBunqyO+kgbqPHLjqHEdqqAfsVB0650oeS6iixXtIK6KXUXRE9ProT8AgSrUboc0I5KopLcfokuuq3pR+omz0sUBgsbeS6QWYFBWWJIhpbBzVm+Tv4i9RiYhg8SbwJxMs8G2sSeeVjzra3nVvJCouRxFfIqc32/q5oTe77s3DIAdJQNaERNFXS0gM24GXmmzdeV2gcERJL1dYnsIJAN4/nv X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(428002)(199003)(189002)(24454002)(51704005)(377424004)(80316001)(59896002)(86362001)(50466002)(2950100001)(65816999)(5001770100001)(33656002)(19580405001)(4001350100001)(85182001)(87936001)(50986999)(105586002)(54356999)(19580395003)(101416001)(46102003)(23676002)(76176999)(87266999)(92566002)(83506001)(62966003)(189998001)(65956001)(77156002)(65806001)(47776003)(36756003)(106466001)(77096005)(3940600001);DIR:OUT;SFP:1102;SCL:1;SRVR:SN1PR0201MB1503;H:atltwp02.amd.com;FPR:;SPF:None;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1503;2:7L/0kN+yGkHALyiRrIszfjhvqZs1lQD60V793v7fv+LP+dJIFgR33TKxCVEl5C3g;3:pNwRcER0nfawxe7OHVtGdIGNGeueOs6sMNmTK/lwpGQGu5hVTtaI62OlNZA7RrU2pl4U4x9i8uVESE4FRo6jrHEgeTEa6ggzYkLd+hWgTsl762DU79FB7XSSfIg1bJSPqW8nPjZhQtavoK/35uy3U2B1R/SFZNIwTfZ1BsXmBWHZavBXrJbrEqGSLgZ/vqsa6IoRDu7B1xRTfcO8ykgimYd9mpJSHtjK/6z0Kxict9DOr+kyWaPe2w305aoqq3Pa;25:/SpQOUG5EtzwbA0EOhWsNUBxZljwGsP+5wSaGvtIAXb5Cspu8pCl/SDc0j+N/uvfQMlHzhi626I7B843NBN3tLsZpZlr4Iz7mfNmA+85FrKFnfoXMAGjbjZqvGx9I7H9/44l8CL6bWcUufc6ActdF/Jq8DYOPkjTF/2hPPS5dLpJM4CSq6LNO0D5YRKRZWW5ru+np7ifJGq/wpeKPCUH/iwaIyx769X67VpJSkfXnSE= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0201MB1503; X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1503;20:NNylOUg798UdXSbAOYOBlWXYLsExcI+Kw0VQ+wQC6eR15qGMrLtGJdoiIEXhSILD+dfaStP8nj4Rc2DSENkxZodHnCDV0lw2fYw/wxZrbbadWTQv/idGe5mg9zIwBKQJ/IrGZ9c4Ie1qfB8IBLZV1p89CjeASLXdze24iqz+oraAtKZZdqbahETIdsxccZqZ1bg9SRU6j57/mqu1vxe1t2+BDgCcSTiacDEB3pAXP5YDYJ2T0+k6U3Q1ApDm/FRajIEflh7TlyewDDXEdhFfjAFNvTJ4mRlFgNUH+GiP0wmRc3onRIDqowhAl2JX/VWcjdPlCHVit9GXr10Y1Mx/k4viQqIbh4nPPS6e1vFgSgIfc4bVoy/cpTtUuEiO3trn3TlgmXnNT8a20XeLEo9MxeVwv15MK5+GUciwwoukV/pQ4xmLYv2GJzU+La9l7zSpKXbiu8pk9R4/xV5ZhTf5hBa3qYWHvLq624xELlEk5ODOeFcZiPUVPDoEnW9p3LKV;4:ESfqrciWt1ot9VaVAssPte7Gw4nwpSWVc4YnIVMLKvCZPBLYFQO33lgT2Lz6b0XggHToEdthK1xjUFQZEZKgGw30V4DV/y01AKQyqmXbTZnhv4O1c5BDjTlYGot4XUBtII73kNDeDkmGK+mekO/ZNLuv8ZYEzCCczYXzmWLPzt0+WzoP8zme35y3TLlwRHMjrfsD2RiBVMhweV513whQLr3EYpxAKfp0tAgtnRSo9MCpLcp52WUTOPaneCY9qketX+I9QFYuMz0IilOp5URtd6KGN2NjcLifKRxCvVlgJeY= SN1PR0201MB1503: X-MS-Exchange-Organization-RulesExecuted X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:SN1PR0201MB1503;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0201MB1503; X-Forefront-PRVS: 0637FCE711 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjAyMDFNQjE1MDM7MjM6RmJNZUVuTkdLR2xVV01ob2FXak4raStw?= =?utf-8?B?Wkd1MGgwVWt2SER6aFFCb3FhRk11QkpxMFV6M25ZSUhLTENKWEprMUp6Y1pz?= =?utf-8?B?T1JiaTlHV3ByVm5rbnE1ZHJmSkdMRWVXbWtDNWZPZml2ZnFuaWorRFZPaUhL?= =?utf-8?B?bmYyR2dNVWlMZWJmR0drUk9DY1JJN1pkdWpibDNvQUpuK0ZWcEh4Zk5vdi9B?= =?utf-8?B?cERyS3FnbFN5Ry9DcHNoaDZ4UzdvcW9SNHpFTlA5RFpGbktGdUhvOURxcklj?= =?utf-8?B?ZDFxbGRudnQwUk9tNTkrK25TTHN5Rms3bXp6QkRQbFJpN2lCVDF0Ym4ybzg5?= =?utf-8?B?TWFCTVJZQXZOL2oyelFMR3o3SFZPc0tOSWp4NWgvS0dGR3VNV20rRDJJUzVw?= =?utf-8?B?cnFWeStiYktHdFEyR2hobGZDejBWb2dDZ05kMUFtckxHaWxteFk5V2J6Qndo?= =?utf-8?B?aDFPMk5LSVpSMm1UQnhGRDg0WklsMlJ3bjlJWjJGdmZnYU5DeUM1UHRnZ1pp?= =?utf-8?B?SUFHZ3EzR28vSWVoTlU0c3JSTE8yR1Nick9XMmRhbTJTcG9yQ0ZIVmxQakRk?= =?utf-8?B?K25ZeUtpVXhOZjlrUEg3dGEvYTY2OG5JZ1hjcncwdEVPOHY4UE0xUWEwWitS?= =?utf-8?B?djZVSThNOWxsZTIzcHBVeUF5OWlYeVJLRTY4akkrN0hIYU5rQ2luNGM5TnZj?= =?utf-8?B?c1FkT09pVWJsczBZRFRWQ1IwNWU4eGJSbVR3SGVHVHMvMFNtbzhxelFSbmdD?= =?utf-8?B?K241bHQvbkVjRjkxcTZJNkQyR3dLeFJBY3hVeDlkOWpCZFpwRTR0Unc3ZXZM?= =?utf-8?B?UXhaaVRhVE1aT1FnMzdtb05mdW5VaGhaMW5KSHhYZVNiRjE2c2dWUHRUb1FS?= =?utf-8?B?dGJZMzA1UGIxSVh5WUE1UWpRckU4cHNGek9jWEpjS0JNTy9yMy8wNFJ3YWFM?= =?utf-8?B?VFhqaGZIZ0JWSGRuakd4VEI1ZVlYbVJNSW9Lb0FIbm1yUEpab1FyMFBNNzZh?= =?utf-8?B?N21pbi9TMi9YMFJTbUYyMVpvZ05EeW5UdHE3MWYrYzFORnNIY25lWEthMVJZ?= =?utf-8?B?VWIvVityZUd2My9EdDljbk5zR0IwMVZrQnlaZ1NYYWRraHBCTGRTMzNQVnVw?= =?utf-8?B?Sm9MUHdxSjNvbHd2UW1TK0RqZ0ZUWGkwaEtFaEs2TDlaZ0o0OVp1K2tQTENa?= =?utf-8?B?MUZHcTJKYklITHdnWm9CS0xIdW0xaERYMnprNzBNNUV3ZFphWDVza2ROVXFs?= =?utf-8?B?NHUxT1I5aUNSbXZFTlZ0QWJMVkdpSW1rU0IrTmlsOFlTNStiRk5WNk5BN1Nk?= =?utf-8?B?d3E4Y1FWV3k5OTd1WFpSN3NpclBvTjQwcmJxdFlVcXFrWEt4dWVSUXY1WjVB?= =?utf-8?B?WEQvc0h0NDFPaVl3ZlBML0k2cWpNcUE3bmYzRHRLeUQrSVRYbkZHUU9kbTRU?= =?utf-8?Q?aGgjaqIg=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1503;5:SM7zYfubiX6E1qf4cfkiewz2dozWVl3tvdQ3Bs1Vgra7+eXQzycaY4DI4RX8MnAJPHDHYSsvdoDi3sdLz1/LJokY5BcxZKBSCrr9vdFwmvXi9/DAgiI96FeKm+Gzc9+h2TbAHFKfAbN+WDxsKEbP3g==;24:KGugIuQ7YtH81XeCqCPi/YM6V+GIDiESVoMStmGNc1LN3x0iKYIPrte+ubXYKp+jPyz3twTESXpeJpEQn6vKi6fE4/nOl/7EgGXuWvLWJdI=;20:1RKCNnuWeRhmrA75uEteTOpd/7aKxWVjNuN7RAsfcLWpL6xHTaoup7vLc6k/2PN3xdlD3xfpS/x98rz640oofw== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2015 08:23:34.8030 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0201MB1503 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 838 Lines: 27 On 14.07.2015 10:18, Alexander Kuleshov wrote: > Hello Alex, > > 2015-07-14 11:11 GMT+06:00 Alex Deucher : >> This patch breaks the build with debugfs enabled. >> > I've tried to built with CONFIG_DEBUG_FS={y/n} and it builds > successfully. Did I miss something? > Maybe I need to enable/disable anything else CONFIG_*? Price question is why do you want to conditionally include this header in the first place? If the kernel isn't build with CONFIG_DEBUG_FS we shouldn't use the defines, but otherwise they don't seem to hurt. Regards, Christian. > > Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/