Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753266AbbGNIsT (ORCPT ); Tue, 14 Jul 2015 04:48:19 -0400 Received: from mx0b-0016ce01.pphosted.com ([67.231.156.153]:6383 "EHLO mx0b-0016ce01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751994AbbGNIsR convert rfc822-to-8bit (ORCPT ); Tue, 14 Jul 2015 04:48:17 -0400 From: Shahed Shaikh To: Christophe JAILLET , Dept-GE Linux NIC Dev CC: netdev , linux-kernel , "kernel-janitors@vger.kernel.org" Subject: RE: [PATCH] net: qlcnic: Deletion of unnecessary memset Thread-Topic: [PATCH] net: qlcnic: Deletion of unnecessary memset Thread-Index: AQHQvaV0yxU6lfbdg0WTfExVDVhTT53aqAaQ Date: Tue, 14 Jul 2015 08:48:10 +0000 Message-ID: <262CB373A6D1F14F9B81E82F74F77D5A472C2759@avmb2.qlogic.org> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.4.10] disclaimer: bypass Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5700 definitions=7861 signatures=670606 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1506180000 definitions=main-1507140124 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1429 Lines: 38 > -----Original Message----- > From: Christophe JAILLET [mailto:christophe.jaillet@wanadoo.fr] > Sent: Tuesday, July 14, 2015 1:22 AM > To: Shahed Shaikh; Dept-GE Linux NIC Dev > Cc: netdev; linux-kernel; kernel-janitors@vger.kernel.org; Christophe JAILLET > Subject: [PATCH] net: qlcnic: Deletion of unnecessary memset > > There is no need to memset memory allocated with vzalloc. > > Signed-off-by: Christophe JAILLET > --- > drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c > b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c > index 2f6cc42..7dbab3c 100644 > --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c > +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c > @@ -2403,7 +2403,6 @@ int qlcnic_alloc_tx_rings(struct qlcnic_adapter > *adapter, > qlcnic_free_tx_rings(adapter); > return -ENOMEM; > } > - memset(cmd_buf_arr, 0, TX_BUFF_RINGSIZE(tx_ring)); > tx_ring->cmd_buf_arr = cmd_buf_arr; > spin_lock_init(&tx_ring->tx_clean_lock); > } Acked-by: Shahed Shaikh Thanks, Shahed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/