Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753373AbbGNIu6 (ORCPT ); Tue, 14 Jul 2015 04:50:58 -0400 Received: from mail-ob0-f193.google.com ([209.85.214.193]:33551 "EHLO mail-ob0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752516AbbGNIuz (ORCPT ); Tue, 14 Jul 2015 04:50:55 -0400 MIME-Version: 1.0 In-Reply-To: <20150714084651.GB4483@dhcp-129-237.nay.redhat.com> References: <20150713021353.282890552@redhat.com> <20150713022634.175021545@redhat.com> <20150714084651.GB4483@dhcp-129-237.nay.redhat.com> Date: Tue, 14 Jul 2015 10:50:54 +0200 X-Google-Sender-Auth: WdEG11aZcvPFR5ecwQI7LDMCKcY Message-ID: Subject: Re: [PATCH 2/3] [PATCH 2/3] kexec: split kexec_load syscall from kexec core code From: Geert Uytterhoeven To: Dave Young Cc: "linux-kernel@vger.kernel.org" , "kexec@lists.infradead.org" , "Eric W. Biederman" , Vivek Goyal , ptesarik@suse.cz, "Theodore Ts'o" , Josh Boyer , David Howells Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2274 Lines: 60 Hi Dave, On Tue, Jul 14, 2015 at 10:46 AM, Dave Young wrote: >> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >> > index 1c50210..20c48b3 100644 >> > --- a/arch/arm/Kconfig >> > +++ b/arch/arm/Kconfig >> > @@ -2001,10 +2001,14 @@ config XIP_PHYS_ADDR >> > be linked for and stored to. This address is dependent on your >> > own flash usage. >> > >> > +config KEXEC_CORE >> > + bool >> > + >> > config KEXEC >> > bool "Kexec system call (EXPERIMENTAL)" >> > depends on (!SMP || PM_SLEEP_SMP) >> > depends on !CPU_V7M >> > + select KEXEC_CORE >> > help >> > kexec is a system call that implements the ability to shutdown your >> > current kernel, and to start another kernel. It is like a reboot >> >> As this KEXEC_CORE is appearing in all arch/*/Kconfig files, I think it's >> time to add an ARCH_HAS_KEXEC symbol (to a common Kconfig file), >> and let arch/*/Kconfig select that if the architecture has kexec support. >> >> Then KEXEC and KEXEC_CORE can live in the common Kconfig file, >> without the need to duplicate it. > > I'm not sure I understand your idea well, do you means like > in arch/Kconfig add ARCH_HAS_KEXEC which depends on KEXEC_CORE? No, ARCH_HAS_KEXEC and all other KEXEC config options in arch/Kconfig. All other KEXEC config options should depend on ARCH_HAS_KEXEC, which can be selected by architectures that support kexec. > How about simply move below chunk to arch/Kconfig instead of introducing > another ARCH_HAS_KEXEC: > config KEXEC_CORE > bool Not all architectures support kexec, hence my proposed dependency on ARCH_HAS_KEXEC. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/