Date: Tue, 14 Jul 2015 11:31:48 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Waiman Long <Waiman.Long@hp.com>
Cc: Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, Scott J Norton <scott.norton@hp.com>,
        Douglas Hatch <doug.hatch@hp.com>
Subject: Re: [PATCH 1/7] locking/pvqspinlock: Only kick CPU at unlock time
Message-ID: <20150714093148.GY18673@twins.programming.kicks-ass.net>
References: <1436647018-49734-1-git-send-email-Waiman.Long@hp.com>
 <1436647018-49734-2-git-send-email-Waiman.Long@hp.com>
 <20150713134828.GH3644@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150713134828.GH3644@twins.programming.kicks-ass.net>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1002
Lines: 29

On Mon, Jul 13, 2015 at 03:48:28PM +0200, Peter Zijlstra wrote:
> @@ -239,9 +265,16 @@ static void pv_wait_head(struct qspinloc
>  			cpu_relax();
>  		}
>  
> -		WRITE_ONCE(pn->state, vcpu_halted);
> +		/*
> +		 * Either pv_kick_node() advanced us and ->state is already
> +		 * vcpu_hashed and this store is superfluous, or this is the
> +		 * first in which case the below cmpxchg() provides the
> +		 * required barriers.
> +		 */
> +		WRITE_ONCE(pn->state, vcpu_hashed);

The easier option is of course to just move this store into the branch
below. That immediately clarifies the logic and avoids the superfluous
store.

>  		if (!lp) { /* ONCE */
>  			lp = pv_hash(lock, pn);
> +
>  			/*
>  			 * lp must be set before setting _Q_SLOW_VAL
>  			 *
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/