Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754787AbbGNJqq (ORCPT ); Tue, 14 Jul 2015 05:46:46 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:52503 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753730AbbGNJqn (ORCPT ); Tue, 14 Jul 2015 05:46:43 -0400 X-Listener-Flag: 11101 Message-ID: <1436867199.9416.16.camel@mtksdaap41> Subject: Re: [PATCH v3 4/5] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS From: James Liao To: Daniel Kurtz CC: Matthias Brugger , Mike Turquette , Stephen Boyd , "Heiko Stubner" , srv_heupstream , Ricky Liang , Rob Herring , Sascha Hauer , "open list:OPEN FIRMWARE AND..." , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Date: Tue, 14 Jul 2015 17:46:39 +0800 In-Reply-To: References: <1436522405-13923-1-git-send-email-jamesjj.liao@mediatek.com> <1436522405-13923-5-git-send-email-jamesjj.liao@mediatek.com> <1436841935.9416.10.camel@mtksdaap41> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1644 Lines: 44 Hi Daniel, On Tue, 2015-07-14 at 11:23 +0800, Daniel Kurtz wrote: > On Tue, Jul 14, 2015 at 10:45 AM, James Liao wrote: > > On Mon, 2015-07-13 at 22:46 +0800, Daniel Kurtz wrote: > >> > +static const struct clk_ops mtk_ref2usb_tx_ops = { > >> > + .is_prepared = mtk_ref2usb_tx_is_prepared, > >> > + .prepare = mtk_ref2usb_tx_prepare, > >> > + .unprepare = mtk_ref2usb_tx_unprepare, > >> > +}; > >> > >> Burying the implementation of this special "mtk_ref2usb" clock in > >> clk-mt8173,c seems a bit awkward. > >> Can you please move it to its own file, like mediatek/clk-usb.c? > > > > Do you mean clk/mediatek/clk-usb.c? > > > > This clock is a MT8173 specific clock, which may not be reused by other > > SoCs. So I think it's not necessary to move it to a separated file. > > Yes, this is a wrapper for a type of clock. I think it would be > better in its own file, rather than embedded in clk-mt8173.c, which is > more about enumerating and initializing the clock tree. > > Perhaps today it is only used for mt8173, but that may not be the case > in the future. OK, I'll separate it from clk-mt8173.c. Ref2usb_tx's control register is located in APMIXEDSYS, which contains most of PLL controlling. Is this clock suitable to implemented mtk-pll.c? Or it's proper to be a separated file such as clk-usb.c? Best regards, James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/