Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755009AbbGNKOD (ORCPT ); Tue, 14 Jul 2015 06:14:03 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:54564 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753873AbbGNKOA (ORCPT ); Tue, 14 Jul 2015 06:14:00 -0400 X-AuditID: cbfee61a-f79516d000006302-b0-55a4e0e63b3f From: Chao Yu To: "'Jaegeuk Kim'" Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <00f301d0ba30$ebe95b80$c3bc1280$@samsung.com> <20150711001715.GA61190@jaegeuk-mac02> <20150713232437.GA64479@jaegeuk-mac02.mot.com> In-reply-to: <20150713232437.GA64479@jaegeuk-mac02.mot.com> Subject: RE: [f2fs-dev] [PATCH] f2fs: fix to release inode page in get_new_data_page Date: Tue, 14 Jul 2015 18:13:05 +0800 Message-id: <00f401d0be1d$cbb489c0$631d9d40$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQH9ctxES6pPCwpWLE5GeRXynQllkwGzsVObAYii9qACJeMB2p1WPQyQ Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPLMWRmVeSWpSXmKPExsVy+t9jQd3nD5aEGsy6zGrxZP0sZotLi9wt Lu+aw+bA7LFpVSebx+4Fn5k8Pm+SC2CO4rJJSc3JLEst0rdL4Mq4desgY8EC1oorfVNYGhhn sXQxcnJICJhIPPg2nwnCFpO4cG89WxcjF4eQwHRGiRUbn7JDOK8YJTbv6mEEqWITUJFY3vEf rENEQE2id98UIJuDg1nAQ2LXsVKI+mOMEj3tVxlB4pwC1hIPH6mDmMICYRKt77NBOlkEVCVO N85iA7F5BSwlmro/sELYghI/Jt8Du41ZQEti/c7jTBC2vMTmNW+ZIe5UkNhx9jUjxAVuEttb 9zFC1IhLbDxyi2UCo9AsJKNmIRk1C8moWUhaFjCyrGIUTS1ILihOSs811CtOzC0uzUvXS87P 3cQIDvZnUjsYVzZYHGIU4GBU4uGdYLkkVIg1say4MvcQowQHs5IIr8VGoBBvSmJlVWpRfnxR aU5q8SFGaQ4WJXHek/k+oUIC6YklqdmpqQWpRTBZJg5OqQZGvccbGF+ENcYrsxn/fSzy9uu6 goCqk1Gmc3l4bmeUC3E9/Ppae9+VxpP3H3YdUWVqe8dy8FxLzxpxowOdMjX3PJ+rvfj05Q4f a83EVXt+X5dlF879x3rXndda7X/7DtFVR364ZHYFX+I8xbG+iW9PR93t84fk81absP2aEjtN TXxD16NrLwSrlFiKMxINtZiLihMBhEufEXICAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 895 Lines: 27 > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Tuesday, July 14, 2015 7:26 AM > To: Chao Yu > Cc: linux-kernel@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to release inode page in get_new_data_page [snip] > > And I don't think we should change error handling method of f2fs_put_dnode > > for just fixing this issue. > > > > How do you think? > > Indeed. I cannot think about other clean way for now. > Instead, how about adding this description in the patch and some comments in > the codes? OK, Please help to review the following patch. :) Thanks, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/