Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754450AbbGNKQV (ORCPT ); Tue, 14 Jul 2015 06:16:21 -0400 Received: from mail-yk0-f180.google.com ([209.85.160.180]:35457 "EHLO mail-yk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753445AbbGNKQT (ORCPT ); Tue, 14 Jul 2015 06:16:19 -0400 MIME-Version: 1.0 In-Reply-To: <1436867199.9416.16.camel@mtksdaap41> References: <1436522405-13923-1-git-send-email-jamesjj.liao@mediatek.com> <1436522405-13923-5-git-send-email-jamesjj.liao@mediatek.com> <1436841935.9416.10.camel@mtksdaap41> <1436867199.9416.16.camel@mtksdaap41> From: Daniel Kurtz Date: Tue, 14 Jul 2015 18:15:58 +0800 X-Google-Sender-Auth: hUGQIh5ijz23J7QQDIMYTRjI9Lk Message-ID: Subject: Re: [PATCH v3 4/5] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS To: James Liao Cc: Matthias Brugger , Mike Turquette , Stephen Boyd , Heiko Stubner , srv_heupstream , Ricky Liang , Rob Herring , Sascha Hauer , "open list:OPEN FIRMWARE AND..." , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-mediatek@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1892 Lines: 50 On Tue, Jul 14, 2015 at 5:46 PM, James Liao wrote: > Hi Daniel, > > On Tue, 2015-07-14 at 11:23 +0800, Daniel Kurtz wrote: >> On Tue, Jul 14, 2015 at 10:45 AM, James Liao wrote: >> > On Mon, 2015-07-13 at 22:46 +0800, Daniel Kurtz wrote: >> >> > +static const struct clk_ops mtk_ref2usb_tx_ops = { >> >> > + .is_prepared = mtk_ref2usb_tx_is_prepared, >> >> > + .prepare = mtk_ref2usb_tx_prepare, >> >> > + .unprepare = mtk_ref2usb_tx_unprepare, >> >> > +}; >> >> >> >> Burying the implementation of this special "mtk_ref2usb" clock in >> >> clk-mt8173,c seems a bit awkward. >> >> Can you please move it to its own file, like mediatek/clk-usb.c? >> > >> > Do you mean clk/mediatek/clk-usb.c? >> > >> > This clock is a MT8173 specific clock, which may not be reused by other >> > SoCs. So I think it's not necessary to move it to a separated file. >> >> Yes, this is a wrapper for a type of clock. I think it would be >> better in its own file, rather than embedded in clk-mt8173.c, which is >> more about enumerating and initializing the clock tree. >> >> Perhaps today it is only used for mt8173, but that may not be the case >> in the future. > > OK, I'll separate it from clk-mt8173.c. > > Ref2usb_tx's control register is located in APMIXEDSYS, which contains > most of PLL controlling. Is this clock suitable to implemented > mtk-pll.c? Or it's proper to be a separated file such as clk-usb.c? I think a separate clk-usb.c might be better since the driver is very different than what is used for the PLLs. Thanks! -Dan > Best regards, > > James > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/