Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754116AbbGNKem (ORCPT ); Tue, 14 Jul 2015 06:34:42 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:41212 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753553AbbGNKek (ORCPT ); Tue, 14 Jul 2015 06:34:40 -0400 Date: Tue, 14 Jul 2015 11:34:21 +0100 From: Russell King - ARM Linux To: Jisheng Zhang Cc: will.deacon@arm.com, mark.rutland@arm.com, daniel.lezcano@linaro.org, Catalin.Marinas@arm.com, Lorenzo.Pieralisi@arm.com, galak@codeaurora.org, agross@codeaurora.org, davidb@codeaurora.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/3] arm: kernel: implement cpuidle_ops with psci backend Message-ID: <20150714103421.GU7557@n2100.arm.linux.org.uk> References: <1436430685-2202-1-git-send-email-jszhang@marvell.com> <1436430685-2202-4-git-send-email-jszhang@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436430685-2202-4-git-send-email-jszhang@marvell.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2489 Lines: 68 On Thu, Jul 09, 2015 at 04:31:25PM +0800, Jisheng Zhang wrote: > This patch implements cpuidle_ops using psci. After this patch, we can > use cpuidle-arm.c with psci backend for both arm and arm64. > > Signed-off-by: Jisheng Zhang > --- > arch/arm/kernel/Makefile | 1 + > arch/arm/kernel/psci_cpuidle.c | 19 +++++++++++++++++++ > 2 files changed, 20 insertions(+) > create mode 100644 arch/arm/kernel/psci_cpuidle.c > > diff --git a/arch/arm/kernel/Makefile b/arch/arm/kernel/Makefile > index 3b995f5..96383d8 100644 > --- a/arch/arm/kernel/Makefile > +++ b/arch/arm/kernel/Makefile > @@ -91,6 +91,7 @@ obj-$(CONFIG_ARM_VIRT_EXT) += hyp-stub.o > ifeq ($(CONFIG_ARM_PSCI),y) > obj-y += psci-call.o > obj-$(CONFIG_SMP) += psci_smp.o > +obj-$(CONFIG_CPU_IDLE) += psci_cpuidle.o > endif > > extra-y := $(head-y) vmlinux.lds > diff --git a/arch/arm/kernel/psci_cpuidle.c b/arch/arm/kernel/psci_cpuidle.c > new file mode 100644 > index 0000000..e7146d2 > --- /dev/null > +++ b/arch/arm/kernel/psci_cpuidle.c > @@ -0,0 +1,19 @@ > +/* > + * Copyright (C) 2015 Marvell Technology Group Ltd. > + * Author: Jisheng Zhang > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +#include > +#include > + > +#include > + > +static struct cpuidle_ops psci_cpuidle_ops __initdata = { > + .suspend = cpu_psci_cpu_suspend, > + .init = cpu_psci_cpu_init_idle, > +}; > +CPUIDLE_METHOD_OF_DECLARE(psci_cpuidle, "psci", &psci_cpuidle_ops); Is there any reason this can't live in the drivers sub-tree? Is there anything specific to 32-bit ARM about this? It looks to me like the right thing to do is to have it as part of drivers/firmware/psci.c. We don't do this for other stuff - we don't have IRQ_CHIP_OF_DECLARE stuff in arch/arm but have the IRQ chip drivers in drivers/irqchip. We keep it all togehter in drivers/irqchip, even when the IRQ chip driver is only useful on ARM. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/