Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753521AbbGNLXi (ORCPT ); Tue, 14 Jul 2015 07:23:38 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51994 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751751AbbGNLXh (ORCPT ); Tue, 14 Jul 2015 07:23:37 -0400 Message-ID: <55A4F137.8010100@suse.de> Date: Tue, 14 Jul 2015 13:23:35 +0200 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Jordan Hargrave , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, jbottomley@odin.com, jordan_hargrave@dell.com Subject: Re: [PATCH] Remove check for SAS expander when querying bay/enclosure IDs. References: <1436797653-9822-1-git-send-email-jordan_hargrave@dell.com> In-Reply-To: <1436797653-9822-1-git-send-email-jordan_hargrave@dell.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1813 Lines: 55 On 07/13/2015 04:27 PM, Jordan Hargrave wrote: > Dell Server backplanes can report bay/enclosure IDs without an > expander present. This patch allows the bay/enclosure IDs to be > propagaged to sysfs.we > > Signed-off-by: Jordan Hargrave > --- > drivers/scsi/scsi_transport_sas.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c > index 9a05819..30d26e3 100644 > --- a/drivers/scsi/scsi_transport_sas.c > +++ b/drivers/scsi/scsi_transport_sas.c > @@ -1222,13 +1222,6 @@ show_sas_rphy_enclosure_identifier(struct device *dev, > u64 identifier; > int error; > > - /* > - * Only devices behind an expander are supported, because the > - * enclosure identifier is a SMP feature. > - */ > - if (scsi_is_sas_phy_local(phy)) > - return -EINVAL; > - > error = i->f->get_enclosure_identifier(rphy, &identifier); > if (error) > return error; > @@ -1248,9 +1241,6 @@ show_sas_rphy_bay_identifier(struct device *dev, > struct sas_internal *i = to_sas_internal(shost->transportt); > int val; > > - if (scsi_is_sas_phy_local(phy)) > - return -EINVAL; > - > val = i->f->get_bay_identifier(rphy); > if (val < 0) > return val; > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N?rnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/