Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752978AbbGNNV4 (ORCPT ); Tue, 14 Jul 2015 09:21:56 -0400 Received: from s3.sipsolutions.net ([5.9.151.49]:33743 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752455AbbGNNVx (ORCPT ); Tue, 14 Jul 2015 09:21:53 -0400 Message-ID: <1436880105.11226.2.camel@sipsolutions.net> Subject: Re: [PATCH] rfkill-gpio: Add support for the Realtek 8723 BT From: Johannes Berg To: Larry Finger , Bastien Nocera , "David S. Miller" Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 14 Jul 2015 15:21:45 +0200 In-Reply-To: <55A50C82.4040107@lwfinger.net> (sfid-20150714_152007_936504_073B238A) References: <1436825494.20249.47.camel@hadess.net> <55A50C82.4040107@lwfinger.net> (sfid-20150714_152007_936504_073B238A) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1277 Lines: 37 On Tue, 2015-07-14 at 08:20 -0500, Larry Finger wrote: > On 07/13/2015 05:11 PM, Bastien Nocera wrote: > > http://thread.gmane.org/gmane.linux.kernel.wireless.general/127706/ > > focu > > s=127896 > > > > Signed-off-by: Bastien Nocera > > Bastien, > > The subject of this patch needs a bit more detail. I know that you > mean the > RTL8723B versions of the Bluetooth devices. The subject should say > this. > > The commit message needs a bit more detail. Referencing the E-mail > thread is OK, > but a bit more is needed. What fails without this change? > > To help keep that patches straight, change the next submission to say > "[PATCH > V2]" in the subject. In addition, after the ---, add a section saying > what > changed in V2. That info is not retained in the final commit message > in the > repo, but it can be very useful to a maintainer. > And while at it, please use links that include the message-id (e.g. mid.gmane.org) so it's searchable even if the archive disappears. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/